Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2759843002: Pump the http version to download system. (Closed)

Created:
3 years, 9 months ago by xingliu
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pump the http version to download system. We need to know the http version to determine if we can use parallel download. So pump the http version from url request. BUG=644352 Review-Url: https://codereview.chromium.org/2759843002 Cr-Commit-Position: refs/heads/master@{#458478} Committed: https://chromium.googlesource.com/chromium/src/+/2a5a15495b82e6d4d5e9c5af354726417734226b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Work on feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/browser/download/download_create_info.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/download/download_create_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_request_core.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/parallel_download_utils.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
xingliu
Hi,PTAL.
3 years, 9 months ago (2017-03-18 21:26:14 UTC) #2
asanka
LGTM https://codereview.chromium.org/2759843002/diff/1/content/browser/download/parallel_download_utils.cc File content/browser/download/parallel_download_utils.cc (right): https://codereview.chromium.org/2759843002/diff/1/content/browser/download/parallel_download_utils.cc#newcode50 content/browser/download/parallel_download_utils.cc:50: // 3. HTTP/1.1 protocol, not QUIC or HTTP/2. ...
3 years, 9 months ago (2017-03-20 20:47:23 UTC) #3
qinmin
lgtm
3 years, 9 months ago (2017-03-21 05:34:23 UTC) #4
xingliu
Thanks for the review. https://codereview.chromium.org/2759843002/diff/1/content/browser/download/parallel_download_utils.cc File content/browser/download/parallel_download_utils.cc (right): https://codereview.chromium.org/2759843002/diff/1/content/browser/download/parallel_download_utils.cc#newcode50 content/browser/download/parallel_download_utils.cc:50: // 3. HTTP/1.1 protocol, not ...
3 years, 9 months ago (2017-03-21 17:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759843002/20001
3 years, 9 months ago (2017-03-21 17:16:31 UTC) #8
David Trainor- moved to gerrit
lgtm % nits
3 years, 9 months ago (2017-03-21 17:28:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759843002/20001
3 years, 9 months ago (2017-03-21 17:59:32 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 18:24:15 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a5a15495b82e6d4d5e9c5af3547...

Powered by Google App Engine
This is Rietveld 408576698