Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/media/media_web_contents_observer.cc

Issue 2759713002: Media: replace HasActiveEffectivelyFullscreenVideo DCHECK with early return. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/media_web_contents_observer.cc
diff --git a/content/browser/media/media_web_contents_observer.cc b/content/browser/media/media_web_contents_observer.cc
index d49b495b0eff968bdd7137a52f6626a93a886318..2098facfba14bcc742a7d8407a4fbeceb03a0f31 100644
--- a/content/browser/media/media_web_contents_observer.cc
+++ b/content/browser/media/media_web_contents_observer.cc
@@ -62,9 +62,7 @@ void MediaWebContentsObserver::MaybeUpdateAudibleState() {
}
bool MediaWebContentsObserver::HasActiveEffectivelyFullscreenVideo() const {
- DCHECK(web_contents()->IsFullscreen());
-
- if (!fullscreen_player_)
+ if (!web_contents()->IsFullscreen() || !fullscreen_player_)
return false;
// Check that the player is active.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698