Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2759673002:
[wasm] Fix typo in F32x4Mul wasm SIMD test (Closed)
|
Created:
3 years, 9 months ago by dusan.simicic Modified:
3 years, 9 months ago CC:
v8-reviews_googlegroups.com, Rodolph Perfetta (ARM), jbramley Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] Fix typo in F32x4Mul wasm SIMD test
BUG=
Review-Url: https://codereview.chromium.org/2759673002
Cr-Commit-Position: refs/heads/master@{#43915}
Committed: https://chromium.googlesource.com/v8/v8/+/9c1a081d4cb76bfa44f0b825826eccff065fc2e9
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
dusan.simicic@imgtec.com changed reviewers: + bbudge@chromium.org, ivica.bogosavljevic@imgtec.com
PTAL
Good eye. lgtm
The CQ bit was checked by dusan.simicic@imgtec.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dusan.simicic@imgtec.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489776509203220, "parent_rev":
"1b696f3cec27d3d304e8036d036c4b99899faf04", "commit_rev":
"9c1a081d4cb76bfa44f0b825826eccff065fc2e9"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Fix typo in F32x4Mul wasm SIMD test BUG= ========== to ========== [wasm] Fix typo in F32x4Mul wasm SIMD test BUG= Review-Url: https://codereview.chromium.org/2759673002 Cr-Commit-Position: refs/heads/master@{#43915} Committed: https://chromium.googlesource.com/v8/v8/+/9c1a081d4cb76bfa44f0b825826eccff065... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/9c1a081d4cb76bfa44f0b825826eccff065...
Message was sent while issue was closed.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
Message was sent while issue was closed.
FYI fails on arm chromebook: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu...
Message was sent while issue was closed.
On 2017/03/18 07:45:47, Michael Achenbach wrote: > FYI fails on arm chromebook: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu... Hi Micheal, I tested this change with ARM simulator built for release and debug modes and didn't see the error. I don't have a chromebook, so feel free to revert the change or maybe somebody else should fix the actual error, because this patch only enables the F32x4Mul test.
Message was sent while issue was closed.
On 2017/03/20 09:24:25, dusan.simicic wrote: > On 2017/03/18 07:45:47, Michael Achenbach wrote: > > FYI fails on arm chromebook: > > > https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm%20-%20debug/bu... > > Hi Micheal, > > I tested this change with ARM simulator built for release and debug modes and > didn't see the error. I don't have a chromebook, so feel free to revert the > change or maybe somebody else should fix the actual error, because this patch > only enables the F32x4Mul test. I can run this on ARM hardware and try to find out why it's failing. I won't have access to it until Wednesday however.
Message was sent while issue was closed.
It'd be great if we could find failures like that in simulator builds. Cc some arm folks. This is about those failures: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/2479 We currently only detect them on real arm hardware. Any chance we could detect those in the simulator? |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
