Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2759663003: Fixed process binding tests (Closed)

Created:
3 years, 9 months ago by shaktisahu
Modified:
3 years, 9 months ago
Reviewers:
jam, Maria
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed process binding tests Changed tests to wait for tab getting loaded completely after a reload. BUG=699384 Review-Url: https://codereview.chromium.org/2759663003 Cr-Commit-Position: refs/heads/master@{#457979} Committed: https://chromium.googlesource.com/chromium/src/+/a627a2107cb27b4707f1f3b4c741636d8b7c5ace

Patch Set 1 #

Patch Set 2 : Without PlzNavigate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
shaktisahu
PTAL
3 years, 9 months ago (2017-03-18 04:37:37 UTC) #9
jam
lgtm, thanks!
3 years, 9 months ago (2017-03-18 19:21:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759663003/20001
3 years, 9 months ago (2017-03-18 21:02:17 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 21:07:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a627a2107cb27b4707f1f3b4c741...

Powered by Google App Engine
This is Rietveld 408576698