Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 275953002: Remove HTTP pipelining support. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, timurrrr+watch_chromium.org, jar (doing other things), grt+watch_chromium.org, eroman, arv+watch_chromium.org, asvitkine+watch_chromium.org, glider+watch_chromium.org, Ilya Sherman, bruening+watch_chromium.org
Visibility:
Public.

Description

Remove HTTP pipelining support. It's been a couple years since anyone worked on it, and there are no plans to enable it by default. Cached pipelining-related server information will automatically be cleared when server information is next saved, so there are no issues on that front. BUG=364557 R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272903

Patch Set 1 #

Patch Set 2 : Merge #

Total comments: 6

Patch Set 3 : Response to willchan's comments (Fix comment typos) #

Patch Set 4 : Remove two test files, delete string #

Patch Set 5 : Merge #

Patch Set 6 : Switch to \n linebreaks (Grr....) #

Patch Set 7 : Retry.... #

Patch Set 8 : Try creating patch on Linux... #

Patch Set 9 : Try creating patch on Linux... #

Patch Set 10 : Merge #

Patch Set 11 : Fix line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -9483 lines) Patch
M chrome/browser/io_thread.h View 1 2 3 4 5 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/metrics/network_stats_uploader.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/metrics/network_stats_uploader.cc View 1 2 3 4 3 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/net/http_pipelining_compatibility_client.h View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/net/http_pipelining_compatibility_client.cc View 1 chunk +0 lines, -542 lines 0 comments Download
D chrome/browser/net/http_pipelining_compatibility_client_unittest.cc View 1 chunk +0 lines, -597 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.h View 1 2 3 4 5 6 7 8 9 4 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager.cc View 1 2 3 4 5 6 7 8 9 10 chunks +4 lines, -80 lines 0 comments Download
M chrome/browser/net/http_server_properties_manager_unittest.cc View 1 2 3 4 5 6 7 8 9 8 chunks +3 lines, -56 lines 0 comments Download
M chrome/browser/resources/net_internals/browser_bridge.js View 4 chunks +0 lines, -23 lines 0 comments Download
D chrome/browser/resources/net_internals/http_pipeline_view.html View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/resources/net_internals/http_pipeline_view.js View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/resources/net_internals/index.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/index.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/net_internals/main.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 4 3 chunks +0 lines, -62 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 5 chunks +0 lines, -79 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/net/test_server_locations.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/net/test_server_locations.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_app_host_distribution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/util/google_chrome_distribution_dummy.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/test/data/http_pipelining/alphabet.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/http_pipelining/alphabet.txt.mock-http-headers View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/webui/net_internals/http_pipeline_view.js View 1 chunk +0 lines, -141 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_util.js View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/webui/net_internals/main.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/net_internals/net_internals_test.js View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M jingle/glue/proxy_resolving_client_socket.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/load_timing_info.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/net_error_list.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/net_log_event_type_list.h View 1 chunk +0 lines, -32 lines 0 comments Download
M net/base/net_log_source_type_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_chunked_decoder.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_network_session.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +244 lines, -253 lines 0 comments Download
M net/http/http_network_session.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +305 lines, -308 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 4 3 chunks +0 lines, -53 lines 0 comments Download
D net/http/http_pipelined_connection.h View 1 chunk +0 lines, -93 lines 0 comments Download
D net/http/http_pipelined_connection_impl.h View 1 chunk +0 lines, -330 lines 0 comments Download
D net/http/http_pipelined_connection_impl.cc View 1 chunk +0 lines, -846 lines 0 comments Download
D net/http/http_pipelined_connection_impl_unittest.cc View 1 chunk +0 lines, -1597 lines 0 comments Download
D net/http/http_pipelined_host.h View 1 chunk +0 lines, -102 lines 0 comments Download
D net/http/http_pipelined_host.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D net/http/http_pipelined_host_capability.h View 1 chunk +0 lines, -23 lines 0 comments Download
D net/http/http_pipelined_host_forced.h View 1 chunk +0 lines, -83 lines 0 comments Download
D net/http/http_pipelined_host_forced.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D net/http/http_pipelined_host_forced_unittest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D net/http/http_pipelined_host_impl.h View 1 chunk +0 lines, -117 lines 0 comments Download
D net/http/http_pipelined_host_impl.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D net/http/http_pipelined_host_impl_unittest.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D net/http/http_pipelined_host_pool.h View 1 chunk +0 lines, -102 lines 0 comments Download
D net/http/http_pipelined_host_pool.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D net/http/http_pipelined_host_pool_unittest.cc View 1 chunk +0 lines, -262 lines 0 comments Download
D net/http/http_pipelined_host_test_util.h View 1 chunk +0 lines, -70 lines 0 comments Download
D net/http/http_pipelined_host_test_util.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D net/http/http_pipelined_network_transaction_unittest.cc View 1 chunk +0 lines, -1037 lines 0 comments Download
D net/http/http_pipelined_stream.h View 1 chunk +0 lines, -115 lines 0 comments Download
D net/http/http_pipelined_stream.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M net/http/http_response_body_drainer.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_response_body_drainer.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/http/http_server_properties.h View 1 2 3 4 5 6 7 8 9 3 chunks +0 lines, -14 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 2 3 4 5 6 7 8 9 5 chunks +0 lines, -27 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 1 2 3 4 5 6 7 8 9 5 chunks +0 lines, -61 lines 0 comments Download
M net/http/http_stream.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M net/http/http_stream_factory.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +245 lines, -250 lines 0 comments Download
M net/http/http_stream_factory_impl.h View 6 chunks +1 line, -21 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 2 3 4 5 6 7 8 9 4 chunks +0 lines, -47 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 1 2 3 4 3 chunks +0 lines, -9 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 1 2 3 4 5 6 7 8 9 10 chunks +4 lines, -88 lines 0 comments Download
M net/http/http_stream_factory_impl_request.h View 3 chunks +0 lines, -11 lines 0 comments Download
M net/http/http_stream_factory_impl_request.cc View 1 2 3 4 6 chunks +3 lines, -47 lines 0 comments Download
M net/net.gypi View 1 2 3 4 4 chunks +0 lines, -24 lines 0 comments Download
M net/socket/buffered_write_stream_socket.h View 1 chunk +0 lines, -83 lines 0 comments Download
M net/socket/buffered_write_stream_socket.cc View 1 chunk +0 lines, -161 lines 0 comments Download
M net/socket/buffered_write_stream_socket_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M net/url_request/url_request.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_request_context_builder.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 17 chunks +69 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest_linux.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
mmenke
Will: This is a huge CL (Though mostly deleting stuff), and I'm not sure where ...
6 years, 7 months ago (2014-05-23 15:35:53 UTC) #1
Alexei Svitkine (slow)
histograms.xml LGTM!
6 years, 7 months ago (2014-05-23 15:43:18 UTC) #2
eroman
*net_internal* LGTM
6 years, 7 months ago (2014-05-23 19:17:59 UTC) #3
willchan no longer on Chromium
LGTM https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h File net/base/load_timing_info.h (right): https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h#newcode43 net/base/load_timing_info.h:43: // In the case of SPD, PAC scripts ...
6 years, 7 months ago (2014-05-23 20:31:21 UTC) #4
willchan no longer on Chromium
Great cleanup. Thanks.
6 years, 7 months ago (2014-05-23 20:31:32 UTC) #5
mmenke
Thanks for the feedback! https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h File net/base/load_timing_info.h (right): https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h#newcode43 net/base/load_timing_info.h:43: // In the case of ...
6 years, 7 months ago (2014-05-23 20:36:36 UTC) #6
mmenke
[+sky]: Please sign off on the chrome/browser/io_thread.* and chrome/browser/metrics changes. Just deleting a couple HTTP-Pipelining ...
6 years, 7 months ago (2014-05-23 20:53:32 UTC) #7
Nicolas Zea
gcm and jingle LGTM
6 years, 7 months ago (2014-05-23 20:54:33 UTC) #8
sky
chrome/browser/io_thread.* LGTM
6 years, 7 months ago (2014-05-23 22:46:05 UTC) #9
grt (UTC plus 2)
chrome/installer/util LGTM
6 years, 7 months ago (2014-05-25 12:42:26 UTC) #10
mmenke
On 2014/05/25 12:42:26, grt wrote: > chrome/installer/util LGTM Thanks! Running into some git + linebreak ...
6 years, 7 months ago (2014-05-25 13:18:52 UTC) #11
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-25 13:19:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/275953002/240001
6 years, 7 months ago (2014-05-25 13:19:17 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 14:02:28 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 14:07:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69680)
6 years, 7 months ago (2014-05-25 14:07:11 UTC) #16
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-26 19:30:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/275953002/300001
6 years, 7 months ago (2014-05-26 19:30:57 UTC) #18
mmenke
6 years, 7 months ago (2014-05-27 00:39:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #11 manually as r272903 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698