Remove HTTP pipelining support.

Remove HTTP pipelining support.

It's been a couple years since anyone worked on it, and there
are no plans to enable it by default.

Cached pipelining-related server information will automatically
be cleared when server information is next saved, so there are
no issues on that front.

BUG=364557
R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272903

[mmenke, 2014-05-23 15:35:53]

Will:  This is a huge CL (Though mostly deleting stuff), and I'm not sure where
else to send it.  Eric can certainly handle the net-internals stuff, but the
rest...

This CL was manually created - there have been a lot of intervening CLs that
cause things not to revert cleanly, and there were a lot of HTTP pipelining CLs,
so just piling together reverts an fixing conflicts didn't seem practical.

[Alexei Svitkine (slow), 2014-05-23 15:43:18]

histograms.xml LGTM!

[eroman, 2014-05-23 19:17:59]

*net_internal* LGTM

[willchan no longer on Chromium, 2014-05-23 20:31:21]

LGTM

https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h
File net/base/load_timing_info.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_inf...
net/base/load_timing_info.h:43: // In the case of SPD, PAC scripts are only run
once for each shared session, so
You got overzealous in deleting the 'Y' :)

https://codereview.chromium.org/275953002/diff/60001/net/http/http_chunked_de...
File net/http/http_chunked_decoder.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/http/http_chunked_de...
net/http/http_chunked_decoder.h:125: // The number of extraraneous unfiltered
bytes after the final CRLF.
extraneous

https://codereview.chromium.org/275953002/diff/60001/net/http/http_stream.h
File net/http/http_stream.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/http/http_stream.h#n...
net/http/http_stream.h:7: // appropriately.  For example, a basichttp stream
will return the transport
basic HTTP stream

[willchan no longer on Chromium, 2014-05-23 20:31:32]

Great cleanup. Thanks.

[mmenke, 2014-05-23 20:36:36]

Thanks for the feedback!

https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_info.h
File net/base/load_timing_info.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/base/load_timing_inf...
net/base/load_timing_info.h:43: // In the case of SPD, PAC scripts are only run
once for each shared session, so
On 2014/05/23 20:31:21, willchan (traveling 5.23-6.27) wrote:
> You got overzealous in deleting the 'Y' :)

Done.

https://codereview.chromium.org/275953002/diff/60001/net/http/http_chunked_de...
File net/http/http_chunked_decoder.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/http/http_chunked_de...
net/http/http_chunked_decoder.h:125: // The number of extraraneous unfiltered
bytes after the final CRLF.
On 2014/05/23 20:31:21, willchan (traveling 5.23-6.27) wrote:
> extraneous

Done....Hrm...It was spelled correctly before, not sure how that ended up
changing.

https://codereview.chromium.org/275953002/diff/60001/net/http/http_stream.h
File net/http/http_stream.h (right):

https://codereview.chromium.org/275953002/diff/60001/net/http/http_stream.h#n...
net/http/http_stream.h:7: // appropriately.  For example, a basichttp stream
will return the transport
On 2014/05/23 20:31:21, willchan (traveling 5.23-6.27) wrote:
> basic HTTP stream

Done.

[mmenke, 2014-05-23 20:53:32]

[+sky]:  Please sign off on the chrome/browser/io_thread.* and
chrome/browser/metrics changes.  Just deleting a couple HTTP-Pipelining related
lines of code.

[+grt]:  Please review chrome/installer/util.

[+zea]:  Please review google_apis/gcm and jingle/glue.  These are trivial
changes removing the code to disable HTTP pipelining, since I'm removing the
feature, so I'll just TBR you if I hear back from the others first.

[Nicolas Zea, 2014-05-23 20:54:33]

gcm and jingle LGTM

[sky, 2014-05-23 22:46:05]

chrome/browser/io_thread.* LGTM

[grt (UTC plus 2), 2014-05-25 12:42:26]

chrome/installer/util LGTM

[mmenke, 2014-05-25 13:18:52]

On 2014/05/25 12:42:26, grt wrote:
> chrome/installer/util LGTM

Thanks!

Running into some git + linebreak try issues, I believe, so expect some CQ
errors as I try to get that sorted out.

[mmenke, 2014-05-25 13:19:08]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-05-25 13:19:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/275953002/240001

[commit-bot: I haz the power, 2014-05-25 14:02:28]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-25 14:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-25 14:07:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[mmenke, 2014-05-26 19:30:22]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2014-05-26 19:30:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/275953002/300001

[mmenke, 2014-05-27 00:39:16]

Committed patchset #11 manually as r272903 (presubmit successful).