Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2759483002: Revert of Cleaned up old navigation code that did not use pending navigation item. (Closed)

Created:
3 years, 9 months ago by rohitrao (ping after 24h)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), ios-reviews+web_chromium.org, noyau+watch_chromium.org, arv+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleaned up old navigation code that did not use pending navigation item. (patchset #4 id:60001 of https://codereview.chromium.org/2751793002/ ) Reason for revert: testReloadInterstitial is failing on an internal bot. For an example, see build 4404 on the internal iphone10-simulator bot. Original issue's description: > Cleaned up old navigation code that did not use pending navigation item. > > Also removed PendingIndexNavigationDisabled experimental setting. > > BUG=692331, 701717 > TEST=Back forward navigation works correctly. > > Review-Url: https://codereview.chromium.org/2751793002 > Cr-Commit-Position: refs/heads/master@{#457459} > Committed: https://chromium.googlesource.com/chromium/src/+/2feaa058530953a2232e6128e16deb31192ad9d2 TBR=kkhorimoto@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=692331, 701717 Review-Url: https://codereview.chromium.org/2759483002 Cr-Commit-Position: refs/heads/master@{#457519} Committed: https://chromium.googlesource.com/chromium/src/+/ac76b4841c801b4dfe13d96a76e767d34593e63d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -48 lines) Patch
M ios/chrome/browser/experimental_flags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/chrome/browser/experimental_flags.mm View 2 chunks +7 lines, -0 lines 0 comments Download
M ios/chrome/browser/resources/Settings.bundle/Experimental.plist View 1 chunk +10 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/visible_url_egtest.mm View 11 chunks +42 lines, -0 lines 0 comments Download
M ios/web/interstitials/web_interstitial_impl.mm View 1 chunk +8 lines, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_web_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 8 chunks +163 lines, -47 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 2 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rohitrao (ping after 24h)
Created Revert of Cleaned up old navigation code that did not use pending navigation item.
3 years, 9 months ago (2017-03-16 19:37:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759483002/1
3 years, 9 months ago (2017-03-16 19:38:22 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 19:39:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac76b4841c801b4dfe13d96a76e7...

Powered by Google App Engine
This is Rietveld 408576698