aura-mus: create an interactive ui test for drag and drop.

aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

This also fixes how we initialize the OSDragExchangeProviderFactory. Env
can be switched from local aura mode to mus mode after initialization in
tests, and we have to handle that case, otherwise any test which
interacts with drag and drop crashes.

BUG=699235
Review-Url: https://codereview.chromium.org/2759463002
Cr-Commit-Position: refs/heads/master@{#457935}
Committed: https://chromium.googlesource.com/chromium/src/+/f4153114859e218c8fe5bef9293f2ec07d9bd276

[Elliot Glaysher, 2017-03-16 17:50:52]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:51:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:54:37]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elliot Glaysher, 2017-03-16 20:50:49]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 20:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 20:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 20:57:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Elliot Glaysher, 2017-03-16 21:01:12]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:01:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-16 21:52:16]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:52:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-16 22:55:45]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 22:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Elliot Glaysher, 2017-03-16 22:59:24]

Description was changed from

==========
aura-mus: create an interactive ui test for drag and drop.

[xxx]: don't commit yet let's see if the trybots barf on this.

BUG=699235
==========

to

==========
aura-mus: Fix regression and add tests for drag and drop, 

This fixes a regression in drag and drop from last week where due.

BUG=699235
==========

[Elliot Glaysher, 2017-03-16 23:02:52]

Description was changed from

==========
aura-mus: Fix regression and add tests for drag and drop, 

This fixes a regression in drag and drop from last week where due.

BUG=699235
==========

to

==========
aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

BUG=699235
==========

[Elliot Glaysher, 2017-03-16 23:05:51]

Description was changed from

==========
aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

BUG=699235
==========

to

==========
aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

This also fixes how we initialize the OSDragExchangeProviderFactory. Env
can be switched from local aura mode to mus mode after initialization in
tests, and we have to handle that case, otherwise any test which
interacts with drag and drop crashes.

BUG=699235
==========

[Elliot Glaysher, 2017-03-16 23:32:57]

erg@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-03-17 00:02:20]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2017-03-17 00:02:20]

sky@chromium.org changed reviewers:
+ tsepez@chromium.org

[sky, 2017-03-17 00:02:21]

LGTM with following addressed.

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
File services/ui/ws/window_server_test_impl.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
services/ui/ws/window_server_test_impl.cc:71: if (!event) {
Correct me if I'm wrong, but because the mojom doesn't declare the event as
optional I don't think event can be null, or at least I think there would be a
binding error if it is.

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.cc:1404: DVLOG(1) << "Bad window passed to
WmSetBounds().";
Bad -> Unknown (just because it's possible the client deleted the window and bad
makes it sound, well, bad).

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
File ui/views/mus/drag_interactive_uitest.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:22: class DraggableView : public
views::View {
Please add comments for classes.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:107: void DragTest_Part3(int64_t
display_id,
Please comment on why you need separate functions for these.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:108: base::Closure quit_closure,
const base::Closure& on these?

[sky, 2017-03-17 00:02:21]

LGTM with following addressed.

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
File services/ui/ws/window_server_test_impl.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
services/ui/ws/window_server_test_impl.cc:71: if (!event) {
Correct me if I'm wrong, but because the mojom doesn't declare the event as
optional I don't think event can be null, or at least I think there would be a
binding error if it is.

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.cc:1404: DVLOG(1) << "Bad window passed to
WmSetBounds().";
Bad -> Unknown (just because it's possible the client deleted the window and bad
makes it sound, well, bad).

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
File ui/views/mus/drag_interactive_uitest.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:22: class DraggableView : public
views::View {
Please add comments for classes.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:107: void DragTest_Part3(int64_t
display_id,
Please comment on why you need separate functions for these.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:108: base::Closure quit_closure,
const base::Closure& on these?

[sky, 2017-03-17 00:02:26]

LGTM with following addressed.

+tsepez for mojom

[commit-bot: I haz the power, 2017-03-17 00:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 00:58:21]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2017-03-17 17:01:11]

lgtm

[Elliot Glaysher, 2017-03-17 17:43:12]

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
File services/ui/ws/window_server_test_impl.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/services/ui/ws/window_s...
services/ui/ws/window_server_test_impl.cc:71: if (!event) {
On 2017/03/17 00:02:21, sky wrote:
> Correct me if I'm wrong, but because the mojom doesn't declare the event as
> optional I don't think event can be null, or at least I think there would be a
> binding error if it is.

Done.

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client.cc:1404: DVLOG(1) << "Bad window passed to
WmSetBounds().";
On 2017/03/17 00:02:21, sky wrote:
> Bad -> Unknown (just because it's possible the client deleted the window and
bad
> makes it sound, well, bad).

Done.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
File ui/views/mus/drag_interactive_uitest.cc (right):

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:107: void DragTest_Part3(int64_t
display_id,
On 2017/03/17 00:02:21, sky wrote:
> Please comment on why you need separate functions for these.

Done.

https://codereview.chromium.org/2759463002/diff/80001/ui/views/mus/drag_inter...
ui/views/mus/drag_interactive_uitest.cc:108: base::Closure quit_closure,
On 2017/03/17 00:02:21, sky wrote:
> const base::Closure& on these?

Done.

[Elliot Glaysher, 2017-03-17 17:43:17]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-03-17 17:43:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2759463002/#ps100001
(title: "sky comments")

[commit-bot: I haz the power, 2017-03-17 17:44:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:47:54]

Failed to apply patch for ui/aura/test/env_test_helper.h:
While running git apply --index -p1;
  error: patch failed: ui/aura/test/env_test_helper.h:30
  error: ui/aura/test/env_test_helper.h: patch does not apply

Patch:       ui/aura/test/env_test_helper.h
Index: ui/aura/test/env_test_helper.h
diff --git a/ui/aura/test/env_test_helper.h b/ui/aura/test/env_test_helper.h
index
321615875800796eebb8f422d6cab3c8d0345efa..20e7277689514ac4be544d44e64797ba77164186
100644
--- a/ui/aura/test/env_test_helper.h
+++ b/ui/aura/test/env_test_helper.h
@@ -30,7 +30,11 @@ class EnvTestHelper {
     env_->is_touch_down_ = false;
   }
 
-  void SetMode(Env::Mode mode) { env_->mode_ = mode; }
+  void SetMode(Env::Mode mode) {
+    env_->mode_ = mode;
+    if (mode == Env::Mode::MUS)
+      env_->EnableMusOSExchangeDataProvider();
+  }
 
   // This circumvents the DCHECKs in Env::SetWindowTreeClient() and should
   // only be used for tests where Env is long lived.

[Elliot Glaysher, 2017-03-17 19:12:40]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2017-03-17 19:12:41]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2759463002/#ps120001
(title: "Merge with master")

[commit-bot: I haz the power, 2017-03-17 19:13:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 20:39:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:39:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2017-03-17 21:10:39]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-03-17 21:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 23:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:11:06]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Elliot Glaysher, 2017-03-18 00:59:51]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:00:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:41:20]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489798791281970,
"parent_rev": "595249cfd33d23fc10a9615b1252afa09ad35153", "commit_rev":
"f4153114859e218c8fe5bef9293f2ec07d9bd276"}

[commit-bot: I haz the power, 2017-03-18 02:42:04]

Description was changed from

==========
aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

This also fixes how we initialize the OSDragExchangeProviderFactory. Env
can be switched from local aura mode to mus mode after initialization in
tests, and we have to handle that case, otherwise any test which
interacts with drag and drop crashes.

BUG=699235
==========

to

==========
aura-mus: Fix regression and add tests for drag and drop,

This fixes a regression in drag and drop from last week where the use of
WindowTreeClients in nested RunLoops caused messages to not be delivered
from the window server, leading to drags never terminating, even after
releasing the mouse button.

This also adds an interactive ui tests which exercises the entire drag
pipeline from the client side in a test against a real instance of the
window server.

This also fixes the test window manager so that it responds to windows
requesting that their bounds be changed.

This also fixes how we initialize the OSDragExchangeProviderFactory. Env
can be switched from local aura mode to mus mode after initialization in
tests, and we have to handle that case, otherwise any test which
interacts with drag and drop crashes.

BUG=699235

Review-Url: https://codereview.chromium.org/2759463002
Cr-Commit-Position: refs/heads/master@{#457935}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4153114859e218c8fe5bef9293f...
==========

[commit-bot: I haz the power, 2017-03-18 02:42:05]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/f4153114859e218c8fe5bef9293f...