Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2759423002: Fix tab state UMAs on Android (Closed)

Created:
3 years, 9 months ago by keishi
Modified:
3 years, 9 months ago
Reviewers:
Yaron, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab state UMAs on Android Fixes the following issues: - On launch, background tabs are recorded as Initial to Active transition. - OnShow is called on the foreground tab right after launch, and is recorded as Active to Active transition. This CL changes when background tabs are created on launch with the TabCreationState.FROZEN_ON_RESTORE, to start in the Inactive state. Also removes reporting of same state transitions. BUG=None Review-Url: https://codereview.chromium.org/2759423002 Cr-Commit-Position: refs/heads/master@{#458672} Committed: https://chromium.googlesource.com/chromium/src/+/99e1c588417175adad9d67179695591ba69383a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabUma.java View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
keishi
PTAL
3 years, 9 months ago (2017-03-21 08:02:49 UTC) #4
Yaron
lgtm but +Dan since I haven't thought about this piece of code in a while.
3 years, 9 months ago (2017-03-21 15:33:13 UTC) #6
gone
lgtm Also fuzzy, but seems reasonable.
3 years, 9 months ago (2017-03-21 17:39:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759423002/1
3 years, 9 months ago (2017-03-22 04:26:01 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 07:41:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99e1c588417175adad9d67179695...

Powered by Google App Engine
This is Rietveld 408576698