Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2759273002:
Adding two smoke tests for DataSaver: (Closed)
DescriptionAdding two smoke tests for DataSaver:
- Loading http://check.googlezip.net/static/ and verifying the image/javascript/css is compressed
- Loading http://check.googlezip.net/block/ and verifying it's not compressed
BUG=680578
Review-Url: https://codereview.chromium.org/2759273002
Cr-Commit-Position: refs/heads/master@{#458887}
Committed: https://chromium.googlesource.com/chromium/src/+/a6651f1e3ed07e5c6a394664723bb6833c01a387
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address code review comment #
Total comments: 2
Patch Set 3 : Update test cases' comments #Messages
Total messages: 23 (11 generated)
bustamante@chromium.org changed reviewers: + bustamante@chromium.org
Looks good, one small comments from me. https://codereview.chromium.org/2759273002/diff/1/tools/chrome_proxy/webdrive... File tools/chrome_proxy/webdriver/smoke.py (right): https://codereview.chromium.org/2759273002/diff/1/tools/chrome_proxy/webdrive... tools/chrome_proxy/webdriver/smoke.py:110: t.LoadURL('http://check.googlezip.net/static') Add a comment here that http://check.googlezip.net/static is a test page that has image/css/javascript resources.
On 2017/03/20 21:32:29, bustamante wrote: > Looks good, one small comments from me. > > https://codereview.chromium.org/2759273002/diff/1/tools/chrome_proxy/webdrive... > File tools/chrome_proxy/webdriver/smoke.py (right): > > https://codereview.chromium.org/2759273002/diff/1/tools/chrome_proxy/webdrive... > tools/chrome_proxy/webdriver/smoke.py:110: > t.LoadURL('http://check.googlezip.net/static') > Add a comment here that http://check.googlezip.net/static is a test page that > has image/css/javascript resources. Thank you for your comment. I have updated accordingly.
Description was changed from ========== Adding two smoke tests for DataSaver: - Loading http://check.googlezip.net/static/ and verifying the image/javascript/css is compressed - Loading http://check.googlezip.net/block/ and verifying it's not compressed BUG=680578 ========== to ========== Adding two smoke tests for DataSaver: - Loading http://check.googlezip.net/static/ and verifying the image/javascript/css is compressed - Loading http://check.googlezip.net/block/ and verifying it's not compressed BUG=680578 ==========
bustamante@chromium.org changed reviewers: + ryansturm@chromium.org
lgtm Ryan do you mind taking a look?
https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... File tools/chrome_proxy/webdriver/smoke.py (right): https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/smoke.py:96: # Ensure the block is working nit: change the comment to "Ensure that block causes resources to load from the origin directly." https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... tools/chrome_proxy/webdriver/smoke.py:106: # Ensure image/css/javascript is compressed nit: Change the comment to "Ensure image, css, and javascript resources are compressed."
On 2017/03/21 17:41:53, Ryan Sturm wrote: > https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... > File tools/chrome_proxy/webdriver/smoke.py (right): > > https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... > tools/chrome_proxy/webdriver/smoke.py:96: # Ensure the block is working > nit: change the comment to "Ensure that block causes resources to load from the > origin directly." > > https://codereview.chromium.org/2759273002/diff/20001/tools/chrome_proxy/webd... > tools/chrome_proxy/webdriver/smoke.py:106: # Ensure image/css/javascript is > compressed > nit: Change the comment to "Ensure image, css, and javascript resources are > compressed." Thank you for your comments. I have updated the comments accordingly.
lgtm
The CQ bit was checked by jiewu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bustamante@chromium.org Link to the patchset: https://codereview.chromium.org/2759273002/#ps40001 (title: "Update test cases' comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by jiewu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by jiewu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490219164046400,
"parent_rev": "56a66e411fe157c498b9a4a77be20a24bf697a31", "commit_rev":
"a6651f1e3ed07e5c6a394664723bb6833c01a387"}
Message was sent while issue was closed.
Description was changed from ========== Adding two smoke tests for DataSaver: - Loading http://check.googlezip.net/static/ and verifying the image/javascript/css is compressed - Loading http://check.googlezip.net/block/ and verifying it's not compressed BUG=680578 ========== to ========== Adding two smoke tests for DataSaver: - Loading http://check.googlezip.net/static/ and verifying the image/javascript/css is compressed - Loading http://check.googlezip.net/block/ and verifying it's not compressed BUG=680578 Review-Url: https://codereview.chromium.org/2759273002 Cr-Commit-Position: refs/heads/master@{#458887} Committed: https://chromium.googlesource.com/chromium/src/+/a6651f1e3ed07e5c6a394664723b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a6651f1e3ed07e5c6a394664723b... |
