third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 2759263002: Add image-first-tests flag to run-webkit-tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2759263002: Add image-first-tests flag to run-webkit-tests (Closed)

Patch Set: Only run compare_txt_fn if !is_testharness_test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index f6ee2901a55ccc73382ab43e6781e17997802f47..503421ba1140a3f9f293e8168871b88e82144e46 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -1569,6 +1569,10 @@ class Port(object):

return False

return True

+ def should_run_pixel_test_first(self, test_input):

+ return any(test_input.test_name.startswith(

+ directory) for directory in self._options.image_first_tests)

def _convert_path(self, path):

"""Handles filename conversion for subprocess command line args."""

# See note above in diff_image() for why we need this.