Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2759263002: Add image-first-tests flag to run-webkit-tests (Closed)
Patch Set: Only run compare_txt_fn if !is_testharness_test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1551 matching lines...) Expand 10 before | Expand all | Expand 10 after
1562 def should_run_as_pixel_test(self, test_input): 1562 def should_run_as_pixel_test(self, test_input):
1563 if not self._options.pixel_tests: 1563 if not self._options.pixel_tests:
1564 return False 1564 return False
1565 if self._options.pixel_test_directories: 1565 if self._options.pixel_test_directories:
1566 return any(test_input.test_name.startswith(directory) for directory in self._options.pixel_test_directories) 1566 return any(test_input.test_name.startswith(directory) for directory in self._options.pixel_test_directories)
1567 # TODO(burnik): Make sure this is the right way to do it. 1567 # TODO(burnik): Make sure this is the right way to do it.
1568 if self.should_use_wptserve(test_input.test_name): 1568 if self.should_use_wptserve(test_input.test_name):
1569 return False 1569 return False
1570 return True 1570 return True
1571 1571
1572 def should_run_pixel_test_first(self, test_input):
1573 return any(test_input.test_name.startswith(
1574 directory) for directory in self._options.image_first_tests)
1575
1572 def _convert_path(self, path): 1576 def _convert_path(self, path):
1573 """Handles filename conversion for subprocess command line args.""" 1577 """Handles filename conversion for subprocess command line args."""
1574 # See note above in diff_image() for why we need this. 1578 # See note above in diff_image() for why we need this.
1575 if sys.platform == 'cygwin': 1579 if sys.platform == 'cygwin':
1576 return cygpath(path) 1580 return cygpath(path)
1577 return path 1581 return path
1578 1582
1579 def _build_path(self, *comps): 1583 def _build_path(self, *comps):
1580 return self._build_path_with_target(self._options.target, *comps) 1584 return self._build_path_with_target(self._options.target, *comps)
1581 1585
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
1635 1639
1636 def __init__(self, base, args, reference_args=None): 1640 def __init__(self, base, args, reference_args=None):
1637 self.name = base 1641 self.name = base
1638 self.base = base 1642 self.base = base
1639 self.args = args 1643 self.args = args
1640 self.reference_args = args if reference_args is None else reference_args 1644 self.reference_args = args if reference_args is None else reference_args
1641 self.tests = set() 1645 self.tests = set()
1642 1646
1643 def __repr__(self): 1647 def __repr__(self):
1644 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1648 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698