Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2759213002: Add auto scrollbars if content would be visible without them. (Closed)

Created:
3 years, 9 months ago by szager1
Modified:
3 years, 9 months ago
Reviewers:
skobes
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add auto scrollbars if content would be visible without them. The check to avoid adding auto scrollbars if the contents aren't visible should consider whether the contents would be visible in the absence of a scrollbar. It's a weird edge case, because adding the scrollbar will hide the content, but it's the only reasonable thing to do. BUG=690115 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2759213002 Cr-Commit-Position: refs/heads/master@{#458348} Committed: https://chromium.googlesource.com/chromium/src/+/8c762e79eef5c9a6d7bce492ec42e8870ab21f8e

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
szager1
3 years, 9 months ago (2017-03-21 03:10:24 UTC) #9
skobes
lgtm
3 years, 9 months ago (2017-03-21 03:44:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759213002/20001
3 years, 9 months ago (2017-03-21 07:48:08 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 07:52:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8c762e79eef5c9a6d7bce492ec42...

Powered by Google App Engine
This is Rietveld 408576698