Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2759143002: Revert of Check detached status before attempting to clear drag transfer state. (Closed)

Created:
3 years, 9 months ago by vasilii
Modified:
3 years, 9 months ago
Reviewers:
sof, dcheng
CC:
chromium-reviews, blink-reviews, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Check detached status before attempting to clear drag transfer state. (patchset #2 id:20001 of https://codereview.chromium.org/2759603002/ ) Reason for revert: The new test fails consistently on WebKit Linux Trusty Leak. 02:51:43.187 21593 worker/2 fast/events/drag-dragend-detaches.html leaked 02:51:43.188 21496 [37229/51558] fast/events/drag-dragend-detaches.html failed unexpectedly (leak detected: ({"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,15],"numberOfLiveSuspendableObjects":[2,3]})) See https://crbug.com/703057 Original issue's description: > Check detached status before attempting to clear drag transfer state. > > Speculatively try to address failing access of dragState() when > clearing out state after 'dragend' has been dispatched. > > R=dcheng > BUG=702516 > > Review-Url: https://codereview.chromium.org/2759603002 > Cr-Commit-Position: refs/heads/master@{#457993} > Committed: https://chromium.googlesource.com/chromium/src/+/a995166eab58770b85268173bf9b34e4bc276171 TBR=dcheng@chromium.org,sigbjornf@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702516 Review-Url: https://codereview.chromium.org/2759143002 Cr-Commit-Position: refs/heads/master@{#458077} Committed: https://chromium.googlesource.com/chromium/src/+/e44e87cea4e3f1106e785f794f5a9d51fb0ed273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
D third_party/WebKit/LayoutTests/fast/events/drag-dragend-detaches.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/drag-dragend-detaches-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/resources/iframe-drag-dragend-detaches.html View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
vasilii
Created Revert of Check detached status before attempting to clear drag transfer state.
3 years, 9 months ago (2017-03-20 14:21:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759143002/1
3 years, 9 months ago (2017-03-20 14:21:33 UTC) #3
sof
unnecessary churn, please see https://codereview.chromium.org/2759603002/#msg20
3 years, 9 months ago (2017-03-20 14:25:25 UTC) #4
vasilii
On 2017/03/20 14:25:25, sof wrote: > unnecessary churn, please see https://codereview.chromium.org/2759603002/#msg20 I'm not waiting for ...
3 years, 9 months ago (2017-03-20 14:29:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759143002/1
3 years, 9 months ago (2017-03-20 14:30:06 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 16:05:11 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e44e87cea4e3f1106e785f794f5a...

Powered by Google App Engine
This is Rietveld 408576698