Issue 275913003: Revert 270173 "Remove SCM_CREDENTIALS fallback code from breakpad"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 275913003: Revert 270173 "Remove SCM_CREDENTIALS fallback code from breakpad" (Closed)

Created:
6 years, 7 months ago by piman

Modified:
6 years, 7 months ago

Reviewers:
mdempsky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 270173 "Remove SCM_CREDENTIALS fallback code from breakpad" build break: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/5169/steps/browser_tests/logs/CDMExpectedCrash > Remove SCM_CREDENTIALS fallback code from breakpad > > Since r266618, we require SCM_CREDENTIALS to work correctly across PID > namespaces, and refuse to run on kernels where it doesn't. > > NOTRY=true > > Review URL: https://codereview.chromium.org/283643004 TBR=mdempsky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270277

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+168 lines, -5 lines)			Patch
M	trunk/src/base/linux_util.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	trunk/src/base/linux_util.cc	View	2 chunks	+121 lines, -0 lines	0 comments	Download
M	trunk/src/components/breakpad/app/breakpad_linux.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	trunk/src/components/breakpad/browser/crash_handler_host_linux.cc	View	4 chunks	+37 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

piman

Committed patchset #1 manually as r270277 (tree was closed).

6 years, 7 months ago (2014-05-14 01:00:44 UTC) #2

Message was sent while issue was closed.

lgtm