Remove SCM_CREDENTIALS fallback code from breakpad

Remove SCM_CREDENTIALS fallback code from breakpad

Since r266618, we require SCM_CREDENTIALS to work correctly across PID
namespaces, and refuse to run on kernels where it doesn't.

NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270173

[Lei Zhang, 2014-05-13 00:09:54]

lgtm

https://codereview.chromium.org/283643004/diff/20001/base/linux_util.cc
File base/linux_util.cc (right):

https://codereview.chromium.org/283643004/diff/20001/base/linux_util.cc#newco...
base/linux_util.cc:78: const char kFindInodeSwitch[] = "--find-inode";
This is dead code as well.

[mdempsky, 2014-05-13 00:11:13]

https://codereview.chromium.org/283643004/diff/20001/base/linux_util.cc
File base/linux_util.cc (right):

https://codereview.chromium.org/283643004/diff/20001/base/linux_util.cc#newco...
base/linux_util.cc:78: const char kFindInodeSwitch[] = "--find-inode";
On 2014/05/13 00:09:54, Lei Zhang wrote:
> This is dead code as well.

Yep, I already mailed out https://codereview.chromium.org/288463002/ to remove
that before noticing this code could be removed too.

[jln (very slow on Chromium), 2014-05-13 00:11:57]

https://codereview.chromium.org/283643004/diff/1/components/breakpad/browser/...
File components/breakpad/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/283643004/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:241: signal_fd =
reinterpret_cast<int*>(CMSG_DATA(hdr))[1];
Shouldn't this be [0]?

[mdempsky, 2014-05-13 00:14:20]

https://codereview.chromium.org/283643004/diff/1/components/breakpad/browser/...
File components/breakpad/browser/crash_handler_host_linux.cc (right):

https://codereview.chromium.org/283643004/diff/1/components/breakpad/browser/...
components/breakpad/browser/crash_handler_host_linux.cc:241: signal_fd =
reinterpret_cast<int*>(CMSG_DATA(hdr))[1];
On 2014/05/13 00:11:58, jln wrote:
> Shouldn't this be [0]?

Yep, already fixed in patch set 2. :)

[jln (very slow on Chromium), 2014-05-13 00:14:31]

On 2014/05/13 00:11:57, jln wrote:
> Shouldn't this be [0]?

ps#1 LGTM

[mdempsky, 2014-05-13 00:17:08]

mark: Please review for more dead code removal from base. Thanks!

[Mark Mentovai, 2014-05-13 14:35:50]

LGTM

[mdempsky, 2014-05-13 16:50:33]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-05-13 16:50:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mdempsky@chromium.org/283643004/20001

[mdempsky, 2014-05-13 19:11:10]

The CQ bit was unchecked by mdempsky@chromium.org

[mdempsky, 2014-05-13 19:11:13]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2014-05-13 19:11:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mdempsky@chromium.org/283643004/20001

[mdempsky, 2014-05-13 19:12:03]

On 2014/05/13 19:11:13, mdempsky wrote:
> The CQ bit was checked by mailto:mdempsky@chromium.org

All relevant trybots for this CL are already green; using NOTRY=true to avoid 2+
hour wait on win_chromium_x64_rel.

[commit-bot: I haz the power, 2014-05-13 19:42:46]

Change committed as 270173