Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 2759113004: Make BrowserAccessibility implement AXPlatformNodeDelegete. (Closed)

Created:
8 months, 1 week ago by dougt
Modified:
8 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make BrowserAccessibility implement AXPlatformNodeDelegete. As part of the fefactoring of BrowserAccessibility, we want to end up with BrowserAccessibility inheriting from AXPlatformNodeDelegate and owning a AXPlatformNode. This change has BrowserAccessibility implmenting a AXPlatformNodeDelegete. This implementation should do nothing. BUG=703369 Review-Url: https://codereview.chromium.org/2759113004 Cr-Commit-Position: refs/heads/master@{#459511} Committed: https://chromium.googlesource.com/chromium/src/+/15dcbd89eadd0958c8347a9dee7a26f7d8f614f6

Patch Set 1 #

Patch Set 2 : Rebase, remove one of the GetData() methods, and update the declaration of GetData to be const #

Messages

Total messages: 17 (11 generated)
dougt
8 months, 1 week ago (2017-03-20 23:50:17 UTC) #2
dmazzoni
lgtm
8 months, 1 week ago (2017-03-21 16:46:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759113004/1
8 months ago (2017-03-24 16:10:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/333579) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
8 months ago (2017-03-24 16:20:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2759113004/20001
8 months ago (2017-03-24 19:08:35 UTC) #14
commit-bot: I haz the power
8 months ago (2017-03-24 19:16:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15dcbd89eadd0958c8347a9dee7a...

Powered by Google App Engine
This is Rietveld efc10ee0f