Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2759063002: Remove most of Widget (FrameViewBase) class from HTMLPlugInElement. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
index a80c0d701a2fdd2344f12c6544c567e789ac3725..7c34fcd6ad447b82105e21124d1cec227d093ea0 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
@@ -36,6 +36,7 @@ class ExceptionState;
class Frame;
class FrameViewBase;
class LayoutPart;
+class PluginView;
class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
public FrameOwner {
@@ -62,6 +63,9 @@ class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
void setWidget(FrameViewBase*);
slangley 2017/03/20 03:05:42 Do we need a TODO here to remove these in followup
haraken 2017/03/20 03:06:35 Add: // TODO(joelhockey): Remove these methods on
joelhockey 2017/03/20 03:54:29 This method is and will still be called for FrameV
FrameViewBase* releaseWidget();
FrameViewBase* ownedWidget() const;
+ void setPlugin(PluginView*);
+ PluginView* releasePlugin();
+ PluginView* ownedPlugin() const;
class UpdateSuspendScope {
STACK_ALLOCATED();

Powered by Google App Engine
This is Rietveld 408576698