Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2759063002: Remove most of Widget (FrameViewBase) class from HTMLPlugInElement. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
index 38f25b8d40c2e9b8f7c4e067aebde7f41c9bd171..646d51738775a046b0d490e0c9c1f4c960005359 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
@@ -288,6 +288,20 @@ FrameViewBase* HTMLFrameOwnerElement::ownedWidget() const {
return m_widget.get();
}
+void HTMLFrameOwnerElement::setPlugin(PluginView* pluginView) {
+ this->setWidget(pluginView);
+}
+
+PluginView* HTMLFrameOwnerElement::releasePlugin() {
+ DCHECK(!m_widget || m_widget->isPluginView());
haraken 2017/03/20 03:06:35 I'd use CHECK until we completely remove FrameView
joelhockey 2017/03/20 03:54:29 I have changed to use toPluginViewOrDie which does
+ return toPluginView(this->releaseWidget());
+}
+
+PluginView* HTMLFrameOwnerElement::ownedPlugin() const {
+ DCHECK(!m_widget || m_widget->isPluginView());
haraken 2017/03/20 03:06:35 Ditto.
joelhockey 2017/03/20 03:54:29 Done
+ return toPluginView(this->ownedWidget());
+}
+
bool HTMLFrameOwnerElement::loadOrRedirectSubframe(
const KURL& url,
const AtomicString& frameName,

Powered by Google App Engine
This is Rietveld 408576698