ChromeOS OOBE: Update alignment of checkbox label.

ChromeOS OOBE: Update alignment of checkbox label.

BUG=702951
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2759043002
Cr-Commit-Position: refs/heads/master@{#458969}
Committed: https://chromium.googlesource.com/chromium/src/+/5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861

[Alexander Alekseev, 2017-03-19 07:58:38]

Description was changed from

==========
ChromeOS OOBE: Update alignment of checkbox label.

BUG=702951
==========

to

==========
ChromeOS OOBE: Update alignment of checkbox label.

BUG=702951
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-03-19 07:58:50]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-19 07:58:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2017-03-19 07:59:06]

alemate@chromium.org changed reviewers:
+ jdufault@chromium.org

[Alexander Alekseev, 2017-03-19 07:59:06]

Please review.

[commit-bot: I haz the power, 2017-03-19 09:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-19 09:14:42]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-03-20 18:39:26]

https://codereview.chromium.org/2759043002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2759043002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.css:40:
#usageStatsLabelContainer {
Can you add a TODO or similar to rename this to usage-stats-label-container? The
naming style in this file (fooBar) is inconsistent with the rest of the code
base.

[Alexander Alekseev, 2017-03-20 22:15:37]

https://codereview.chromium.org/2759043002/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_eula.css (right):

https://codereview.chromium.org/2759043002/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_eula.css:40:
#usageStatsLabelContainer {
On 2017/03/20 18:39:26, jdufault wrote:
> Can you add a TODO or similar to rename this to usage-stats-label-container?
The
> naming style in this file (fooBar) is inconsistent with the rest of the code
> base.

Actually all md-style OOBE files have all ID in this format, because of polymer
$ hash. It seems to be more convenient to write this.$.id instead of
this.$['id']. WDYT?

[Alexander Alekseev, 2017-03-22 00:38:46]

Friendly ping.

[jdufault, 2017-03-22 16:49:54]

lgtm

[Alexander Alekseev, 2017-03-22 22:58:47]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:59:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 01:25:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490223527326630, "parent_rev":
"aa9787bbd7919d6114c6bb40fe8e30cdae424ba1", "commit_rev":
"5a72306fa280ea7fcd5fcdf8bf6b1f7db9488861"}

[commit-bot: I haz the power, 2017-03-23 01:26:37]

Description was changed from

==========
ChromeOS OOBE: Update alignment of checkbox label.

BUG=702951
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS OOBE: Update alignment of checkbox label.

BUG=702951
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2759043002
Cr-Commit-Position: refs/heads/master@{#458969}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a72306fa280ea7fcd5fcdf8bf6b...
==========

[commit-bot: I haz the power, 2017-03-23 01:26:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a72306fa280ea7fcd5fcdf8bf6b...