Factor GrTexture into public GrTexture and private GrTextureImpl.

Factor GrTexture into public GrTexture and private GrTextureImpl.

Committed: http://code.google.com/p/skia/source/detail?r=14680

Committed: http://code.google.com/p/skia/source/detail?r=14687

[bsalomon, 2014-05-09 14:44:15]

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:72: GrTextureImpl* impl() { return
reinterpret_cast<GrTextureImpl*>(this); }
This can only be static_cast if GrTextureImpl is already defined. The forward
declaration doesn't communicate the inheritance.

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:107: class GrTextureImpl : public GrTexture {
Kept this in the same file for the initial review. A follow on change will add
src/gpu/GrTextureImpl.h and move this class there.

[robertphillips, 2014-05-09 14:57:22]

lgtm

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:108: public:
Name here

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:167: 
Can't GrTexture just access fMipMapsStatus via the public API?

https://codereview.chromium.org/275903002/diff/1/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/275903002/diff/1/src/gpu/GrTexture.cpp#newcod...
src/gpu/GrTexture.cpp:187: 
These guys will move out, right?

[bsalomon, 2014-05-09 15:10:39]

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:108: public:
On 2014/05/09 14:57:22, robertphillips wrote:
> Name here

Done.

https://codereview.chromium.org/275903002/diff/1/include/gpu/GrTexture.h#newc...
include/gpu/GrTexture.h:167: 
On 2014/05/09 14:57:22, robertphillips wrote:
> Can't GrTexture just access fMipMapsStatus via the public API?

It was accessing the flags enum. But I added a public bool hasMipMaps() to
obviate the need for the enum values and removed the friend.

https://codereview.chromium.org/275903002/diff/1/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/275903002/diff/1/src/gpu/GrTexture.cpp#newcod...
src/gpu/GrTexture.cpp:187: 
On 2014/05/09 14:57:22, robertphillips wrote:
> These guys will move out, right?

I wasn't planning on that. There are only a few functions, the file is only a
little over 200 lines, and GrTexture/GrTextureImpl are pretty intimate with each
other. That said, I don't object to separating if you'd prefer it.

[bsalomon, 2014-05-09 17:26:42]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-09 17:27:35]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/275903002/20001

[commit-bot: I haz the power, 2014-05-09 17:38:05]

Change committed as 14680

[bsalomon, 2014-05-09 18:01:26]

A revert of this CL has been created in
https://codereview.chromium.org/278073002/ by bsalomon@google.com.

The reason for reverting is: Breaks chrome build..

[bsalomon, 2014-05-09 20:39:16]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-09 20:40:40]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/275903002/40001

[commit-bot: I haz the power, 2014-05-09 20:46:55]

Change committed as 14687