third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h - Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h

Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval. (Closed)

Patch Set: Rebased. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/orientation-event/devicemotionevent-init-expected.txt ('k') | third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h

diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h

index 9bc93290b7b338220299bd688e427ecb9751bb6b..600bdd541a5baa81e174add0744febc11a4d8239 100644

--- a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h

+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h

@@ -118,7 +118,6 @@ class DeviceMotionData final : public GarbageCollected<DeviceMotionData> {

static DeviceMotionData* create(Acceleration*,

Acceleration* accelerationIncludingGravity,

RotationRate*,

- bool canProvideInterval,

double interval);

static DeviceMotionData* create(const DeviceMotionEventInit&);

static DeviceMotionData* create(const device::MotionData&);

@@ -130,7 +129,6 @@ class DeviceMotionData final : public GarbageCollected<DeviceMotionData> {

}

RotationRate* getRotationRate() const { return m_rotationRate.get(); }

- bool canProvideInterval() const { return m_canProvideInterval; }

double interval() const { return m_interval; }

bool canProvideEventData() const;

@@ -140,13 +138,11 @@ class DeviceMotionData final : public GarbageCollected<DeviceMotionData> {

DeviceMotionData(Acceleration*,

Acceleration* accelerationIncludingGravity,

RotationRate*,

- bool canProvideInterval,

double interval);

Member<Acceleration> m_acceleration;

Member<Acceleration> m_accelerationIncludingGravity;

Member<RotationRate> m_rotationRate;

- bool m_canProvideInterval;

double m_interval;

};