Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp

Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval. (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
index 1d299ce4749040c0dfb8b64969c11c99e10ddc05..be0fbfaec3672b7d8756e098335459fcc5c78fe9 100644
--- a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
@@ -105,10 +105,9 @@ DeviceMotionData* DeviceMotionData::create(
Acceleration* acceleration,
Acceleration* accelerationIncludingGravity,
RotationRate* rotationRate,
- bool canProvideInterval,
double interval) {
return new DeviceMotionData(acceleration, accelerationIncludingGravity,
- rotationRate, canProvideInterval, interval);
+ rotationRate, interval);
}
DeviceMotionData* DeviceMotionData::create(const DeviceMotionEventInit& init) {
@@ -123,7 +122,7 @@ DeviceMotionData* DeviceMotionData::create(const DeviceMotionEventInit& init) {
init.hasRotationRate()
? DeviceMotionData::RotationRate::create(init.rotationRate())
: nullptr,
- init.hasInterval(), init.hasInterval() ? init.interval() : 0);
+ init.hasInterval() ? init.interval() : 0);
}
DeviceMotionData* DeviceMotionData::create(const device::MotionData& data) {
@@ -142,21 +141,18 @@ DeviceMotionData* DeviceMotionData::create(const device::MotionData& data) {
data.hasRotationRateAlpha, data.rotationRateAlpha,
data.hasRotationRateBeta, data.rotationRateBeta,
data.hasRotationRateGamma, data.rotationRateGamma),
- true, data.interval);
+ data.interval);
}
-DeviceMotionData::DeviceMotionData()
- : m_canProvideInterval(false), m_interval(0) {}
+DeviceMotionData::DeviceMotionData() : m_interval(0) {}
DeviceMotionData::DeviceMotionData(Acceleration* acceleration,
Acceleration* accelerationIncludingGravity,
RotationRate* rotationRate,
- bool canProvideInterval,
double interval)
: m_acceleration(acceleration),
m_accelerationIncludingGravity(accelerationIncludingGravity),
m_rotationRate(rotationRate),
- m_canProvideInterval(canProvideInterval),
m_interval(interval) {}
DEFINE_TRACE(DeviceMotionData) {

Powered by Google App Engine
This is Rietveld 408576698