Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp

Issue 2758933002: Fix default initialization for DeviceMotionEvent.interval. (Closed)
Patch Set: Fix layout test expectations. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
diff --git a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
index 1975a4963a52b3e27bd5563f661f5d9e91a12a8c..ec5505cded9ee941b1200598d5cd20164fbd3111 100644
--- a/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
+++ b/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
@@ -81,11 +81,7 @@ DeviceRotationRate* DeviceMotionEvent::rotationRate() {
}
double DeviceMotionEvent::interval(bool& isNull) const {
- if (m_deviceMotionData->canProvideInterval())
- return m_deviceMotionData->interval();
-
- isNull = true;
- return 0;
+ return m_deviceMotionData->interval();
timvolodine 2017/03/22 17:05:27 isNull = false; ? also likely the isNull etc can
Reilly Grant (use Gerrit) 2017/03/22 17:13:33 The generated bindings code initializes isNull to
timvolodine 2017/03/22 18:27:26 In that case perhaps add a this as a comment? Othe
Reilly Grant (use Gerrit) 2017/03/22 18:38:03 It is required by the bindings code because the at
}
const AtomicString& DeviceMotionEvent::interfaceName() const {

Powered by Google App Engine
This is Rietveld 408576698