Fix default initialization for DeviceMotionEvent.interval.

third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 63 matching lines @@
     return nullptr;
 
   if (!m_rotationRate)
     m_rotationRate =
         DeviceRotationRate::create(m_deviceMotionData->getRotationRate());
 
   return m_rotationRate.get();
 }
 
 double DeviceMotionEvent::interval(bool& isNull) const {
-  if (m_deviceMotionData->canProvideInterval())
-    return m_deviceMotionData->interval();
-
-  isNull = true;
-  return 0;
+  return m_deviceMotionData->interval();

[timvolodine, 2017/03/22 17:05:27]

isNull = false; ?

also likely the isNull etc can be removed altogether if the idl is updated..
maybe a follow-up patch?

[Reilly Grant (use Gerrit), 2017/03/22 17:13:33]

The generated bindings code initializes isNull to false before calling this
function.

I have submitted a pull request to the deviceorientation spec which makes this
attribute non-nullable.

[timvolodine, 2017/03/22 18:27:26]

In that case perhaps add a this as a comment? Otherwise think not very clear
what happens with this by reference parameter (and why it's needed at all)
yes, thanks, I've merged it.

[Reilly Grant (use Gerrit), 2017/03/22 18:38:03]

It is required by the bindings code because the attribute is nullable. I've
added a line to explicitly set it to false though my next patch will delete it
since it changes the IDL to make the attribute non-nullable.

 }
 
 const AtomicString& DeviceMotionEvent::interfaceName() const {
   return EventNames::DeviceMotionEvent;
 }
 
 DEFINE_TRACE(DeviceMotionEvent) {
   visitor->trace(m_deviceMotionData);
   visitor->trace(m_acceleration);
   visitor->trace(m_accelerationIncludingGravity);
   visitor->trace(m_rotationRate);
   Event::trace(visitor);
 }
 
 }  // namespace blink