Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2758873002: [Merge M58] arc: Fix crash on deferred app launch. (Closed)

Created:
3 years, 9 months ago by khmel
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge M58] arc: Fix crash on deferred app launch. This fixes regression due recent shelf refactoring when meaning of TYPE_APP AND TYPE_SHORTCUT_APP was changed. ARC defered launcher is allowed only over shortcuts. TEST=Manually BUG=701152 TBR=msw@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2747983002 Cr-Commit-Position: refs/heads/master@{#456830} (cherry picked from commit b1a39b125d0cc6b6994b92089ebc877b693a6ddd) Review-Url: https://codereview.chromium.org/2758873002 Cr-Commit-Position: refs/branch-heads/3029@{#272} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/92716b1689b94ce7c3edf5facdf858c35fa50766

Patch Set 1 #

Patch Set 2 : resolve merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -2 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758873002/20001
3 years, 9 months ago (2017-03-17 18:15:05 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 18:35:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92716b1689b94ce7c3edf5facdf8...

Powered by Google App Engine
This is Rietveld 408576698