Fix error msg of OffscreenCanvas.commit() on gpu compositing

Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.nearest_neighbor indicates the desired
filtering effect on the rendered quad, the resource.filter actually
indicates the filtering algorithm on the resource inherently. To remove
this error msg whilst maintaining the correctness of filtering algorithm
applied on accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599
Review-Url: https://codereview.chromium.org/2758863003
Cr-Commit-Position: refs/heads/master@{#460488}
Committed: https://chromium.googlesource.com/chromium/src/+/d49d131187ed4e0c3dd5124cdd6ba41cbc06a2a9

[xlai (Olivia), 2017-03-28 16:24:37]

Description was changed from

==========
[WIP]

BUG=692599
==========

to

==========
Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.filter indicates the desired filtering
effect on the rendered quad, the resource.filter actually indicates the
filtering algorithm on the resource inherently. To remove this error msg
whilst maintaining the correctness of filtering algorithm applied on
accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599
==========

[xlai (Olivia), 2017-03-28 16:24:37]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2017-03-28 16:26:47]

Description was changed from

==========
Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.filter indicates the desired filtering
effect on the rendered quad, the resource.filter actually indicates the
filtering algorithm on the resource inherently. To remove this error msg
whilst maintaining the correctness of filtering algorithm applied on
accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599
==========

to

==========
Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.nearest_neighbor indicates the desired
filtering effect on the rendered quad, the resource.filter actually
indicates the filtering algorithm on the resource inherently. To remove
this error msg whilst maintaining the correctness of filtering algorithm
applied on accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599
==========

[xlai (Olivia), 2017-03-29 17:22:24]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:22:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2017-03-29 17:24:14]

The CQ bit was unchecked by xlai@chromium.org

[Justin Novosad, 2017-03-29 18:48:48]

lgtm

[xlai (Olivia), 2017-03-29 19:00:23]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2017-03-29 19:01:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 19:27:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490814023159280,
"parent_rev": "50cdd3373b5fd13e9f4e1354d14e3f1c782e4b35", "commit_rev":
"d49d131187ed4e0c3dd5124cdd6ba41cbc06a2a9"}

[commit-bot: I haz the power, 2017-03-29 19:28:11]

Description was changed from

==========
Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.nearest_neighbor indicates the desired
filtering effect on the rendered quad, the resource.filter actually
indicates the filtering algorithm on the resource inherently. To remove
this error msg whilst maintaining the correctness of filtering algorithm
applied on accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599
==========

to

==========
Fix error msg of OffscreenCanvas.commit() on gpu compositing

The previous CL, https://codereview.chromium.org/2607373002/, that fixed
 a resizing problem in accelerated 2d canvas, has introduced this error
 message "GL_INVALID_ENUM : glTexParameteri: param was GL_FALSE" because
the resource.filter in OffscreenCanvasFrameDispatcherImpl is not set.
This causes ResourceProvider::DeleteAndReturnUnusedResourcesToChild to run
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, 0) as it discovers
a difference between original_filter and filter in resource when closing
down browser.

We then find out that whilst quad.nearest_neighbor indicates the desired
filtering effect on the rendered quad, the resource.filter actually
indicates the filtering algorithm on the resource inherently. To remove
this error msg whilst maintaining the correctness of filtering algorithm
applied on accelerated 2d canvas, we need to specify the resource filter to 
GL_NEAREST. Then the overriding mechanism about resource->original_filter
and resource->filter in resource_provider.cc will be able to function
correctly.

In addition, I added GL_TEXTURE_MAG_FILTER as there is no reason why
we only apply linear filtering on MIN_FILTER and not MAG_FILTER.

BUG=692599

Review-Url: https://codereview.chromium.org/2758863003
Cr-Commit-Position: refs/heads/master@{#460488}
Committed:
https://chromium.googlesource.com/chromium/src/+/d49d131187ed4e0c3dd5124cdd6b...
==========

[commit-bot: I haz the power, 2017-03-29 19:28:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d49d131187ed4e0c3dd5124cdd6b...