Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2758863002: cros: Fix clusterfuzz crash opening stylus palette (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
jdufault
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix clusterfuzz crash opening stylus palette Clusterfuzz skips the login pathway and injects keystrokes immediately on startup. This can trigger accelerators before the status area is initialized. Add a null check -- this case doesn't happen in production. BUG=702480 TEST=clusterfuzz Review-Url: https://codereview.chromium.org/2758863002 Cr-Commit-Position: refs/heads/master@{#457827} Committed: https://chromium.googlesource.com/chromium/src/+/8a9f744dfa2a4299d50b3474b0d9699070158e0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ash/common/accelerators/accelerator_controller.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
James Cook
jdufault, please take a look.
3 years, 9 months ago (2017-03-17 17:40:57 UTC) #4
jdufault
lgtm
3 years, 9 months ago (2017-03-17 17:51:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758863002/1
3 years, 9 months ago (2017-03-17 17:52:23 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 18:40:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a9f744dfa2a4299d50b3474b0d9...

Powered by Google App Engine
This is Rietveld 408576698