Issue 2758773004: Temporarily add CHECKs to VisualViewport::didSetScaleAndLocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2758773004: Temporarily add CHECKs to VisualViewport::didSetScaleAndLocation (Closed)

Created:
3 years, 9 months ago by bokan

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/2987

Project:
chromium

Visibility:
Public.

Temporarily add CHECKs to VisualViewport::didSetScaleAndLocation Adding CHECKS to help track down why we're getting infinite recursion in this function. It looks like that may happen if the scale of offset ever become NaN. BUG=665083, 702771 Review-Url: https://codereview.chromium.org/2754323003 Cr-Commit-Position: refs/heads/master@{#457920} (cherry picked from commit 3685db28900ee3e99c5e2e6ce8bfecb78805f1de) Review-Url: https://codereview.chromium.org/2758773004 . Cr-Commit-Position: refs/branch-heads/2987@{#846} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/12b6df011abab4773df645d7a39cdab42f1336b2

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/frame/VisualViewport.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

bokan

3 years, 9 months ago (2017-03-18 01:52:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
12b6df011abab4773df645d7a39cdab42f1336b2.