Clean up MediaSessionImpl state interfaces

Clean up MediaSessionImpl state interfaces

This CL cleans up the MediaSessionImpl state interfaces,
especially "suspended" and "paused".

BUG=702627
Review-Url: https://codereview.chromium.org/2758773003
Cr-Commit-Position: refs/heads/master@{#458791}
Committed: https://chromium.googlesource.com/chromium/src/+/fa29809ee94916e79cd5e25060cd03ed3b1bb46f

[Zhiqiang Zhang (Slow), 2017-03-17 15:44:39]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2017-03-20 22:12:47]

content/browser/media/session lgtm

I'm worried that the content/public review might cause renaming of these methods
again...
Do you think you could add content/public changes here or maybe do them first?
Overall looks better although some documentation about what the states mean
exactly and how they work together would be good (is there an .md file already
in the code base, maybe just link to it then?).

https://codereview.chromium.org/2758773003/diff/1/content/browser/media/sessi...
File content/browser/media/session/media_session_impl.h (right):

https://codereview.chromium.org/2758773003/diff/1/content/browser/media/sessi...
content/browser/media/session/media_session_impl.h:72: // Only visible to tests.
nit: this comment is not true?
do we have a good comment that explains what ACTIVE/SUSPENDED/INACTIVE and
"actually paused" vs "paused" mean?

[Zhiqiang Zhang (Slow), 2017-03-22 13:52:51]

On 2017/03/20 at 22:12:47, avayvod wrote:
> I'm worried that the content/public review might cause renaming of these
methods again...
> Do you think you could add content/public changes here or maybe do them first?
> Overall looks better although some documentation about what the states mean
exactly and how they work together would be good (is there an .md file already
in the code base, maybe just link to it then?).

Now we no longer to expose the interfaces in content/public.
This is for fixing https://crbug.com/702153, but it is solved in another way.

https://codereview.chromium.org/2758773003/diff/1/content/browser/media/sessi...
File content/browser/media/session/media_session_impl.h (right):

https://codereview.chromium.org/2758773003/diff/1/content/browser/media/sessi...
content/browser/media/session/media_session_impl.h:72: // Only visible to tests.
On 2017/03/20 at 22:12:47, whywhat wrote:
> nit: this comment is not true?

Done.

> do we have a good comment that explains what ACTIVE/SUSPENDED/INACTIVE and
"actually paused" vs "paused" mean?

We already have it (audio_focus.md)

[Zhiqiang Zhang (Slow), 2017-03-22 13:53:31]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 13:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2017-03-22 13:54:35]

Description was changed from

==========
Clean up MediaSessionImpl state interfaces

This CL cleans up the MediaSessionImpl state interfaces, especially "suspended"
and "paused". A follow-up CL will expose the cleaned-up interfaces to
content/public.

BUG=702627
==========

to

==========
Clean up MediaSessionImpl state interfaces

This CL cleans up the MediaSessionImpl state interfaces,
especially "suspended" and "paused".

BUG=702627
==========

[commit-bot: I haz the power, 2017-03-22 14:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 14:02:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Zhiqiang Zhang (Slow), 2017-03-22 15:57:10]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-03-22 15:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2758773003/#ps40001
(title: "fixed build")

[commit-bot: I haz the power, 2017-03-22 15:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 17:24:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490198230711790,
"parent_rev": "ab0b8e3ab6e7c70b740be07e63aaebdc0418a95c", "commit_rev":
"fa29809ee94916e79cd5e25060cd03ed3b1bb46f"}

[commit-bot: I haz the power, 2017-03-22 17:25:39]

Description was changed from

==========
Clean up MediaSessionImpl state interfaces

This CL cleans up the MediaSessionImpl state interfaces,
especially "suspended" and "paused".

BUG=702627
==========

to

==========
Clean up MediaSessionImpl state interfaces

This CL cleans up the MediaSessionImpl state interfaces,
especially "suspended" and "paused".

BUG=702627

Review-Url: https://codereview.chromium.org/2758773003
Cr-Commit-Position: refs/heads/master@{#458791}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa29809ee94916e79cd5e25060cd...
==========

[commit-bot: I haz the power, 2017-03-22 17:25:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/fa29809ee94916e79cd5e25060cd...