📰 Refresh the tiles when a removal is undone

[NTP Tiles] Refresh the tiles when a removal is undone

BUG=701253
Review-Url: https://codereview.chromium.org/2758753003
Cr-Commit-Position: refs/heads/master@{#457810}
Committed: https://chromium.googlesource.com/chromium/src/+/53f956f3080cfc242b5639e636e34ffde7e3962f

[dgn, 2017-03-17 13:57:49]

Description was changed from

==========
[NTP Tiles] Refresh the tiles when a removal is undone

BUG=701253
==========

to

==========
[NTP Tiles] Refresh the tiles when a removal is undone

BUG=701253
==========

[dgn, 2017-03-17 13:57:49]

dgn@chromium.org changed reviewers:
+ mvanouwerkerk@chromium.org

[dgn, 2017-03-17 13:57:54]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 13:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgn, 2017-03-17 14:00:11]

PTAL. I'll add tests in a separate CL to make merging this easier.

[commit-bot: I haz the power, 2017-03-17 14:32:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 14:32:21]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2017-03-17 15:53:07]

lgtm with nit

https://codereview.chromium.org/2758753003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
(right):

https://codereview.chromium.org/2758753003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java:56:
void removeMostVisitedItem(Tile tile, @Nullable Callback<String>
removalUndoneCallback);
Why is the callback nullable? Please document what the callback string argument
represents.

[dgn, 2017-03-17 16:13:45]

Thanks!

https://codereview.chromium.org/2758753003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java
(right):

https://codereview.chromium.org/2758753003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroup.java:56:
void removeMostVisitedItem(Tile tile, @Nullable Callback<String>
removalUndoneCallback);
On 2017/03/17 15:53:07, Michael van Ouwerkerk wrote:
> Why is the callback nullable? Please document what the callback string
argument
> represents.

I intended the callback to be optional but there is only one user anyway so
there is no point. Removed Nullable. Added explanation about the argument.

[dgn, 2017-03-17 16:13:49]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-03-17 16:13:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/2758753003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-17 16:14:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:16:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:17:00]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgn, 2017-03-17 17:10:37]

The CQ bit was checked by dgn@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 17:51:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489770637602350,
"parent_rev": "cabebfee33715afb9e577f6d133898b408390ab1", "commit_rev":
"53f956f3080cfc242b5639e636e34ffde7e3962f"}

[commit-bot: I haz the power, 2017-03-17 17:51:57]

Description was changed from

==========
[NTP Tiles] Refresh the tiles when a removal is undone

BUG=701253
==========

to

==========
[NTP Tiles] Refresh the tiles when a removal is undone

BUG=701253

Review-Url: https://codereview.chromium.org/2758753003
Cr-Commit-Position: refs/heads/master@{#457810}
Committed:
https://chromium.googlesource.com/chromium/src/+/53f956f3080cfc242b5639e636e3...
==========

[commit-bot: I haz the power, 2017-03-17 17:51:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53f956f3080cfc242b5639e636e3...