Avoid to use the method pointer to Callback<>::Run on gmock tests

Avoid to use the method pointer to Callback<>::Run on gmock tests

This CL replaces a problematic method pointers to Callback::Run with
testing::CreateFunctor.

The method pointer to Callback::Run prevents to make it a template
method or to overload it for cleaner implementation.

Review-Url: https://codereview.chromium.org/2758713002
Cr-Commit-Position: refs/heads/master@{#458018}
Committed: https://chromium.googlesource.com/chromium/src/+/2e53fef9596667824f9f0467fb6b2eabf1eb121e

[tzik, 2017-03-17 04:49:08]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 04:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-03-17 04:54:15]

Description was changed from

==========
Avoid to use the method pointer to Callback<>::Run
==========

to

==========
Avoid to use the method pointer to Callback<>::Run on gmock tests

This CL replaces a problematic method pointers to Callback::Run with
testing::CreateFunctor.

The method pointer to Callback::Run prevents to make it a template
method or to overload it for cleaner implementation.
==========

[commit-bot: I haz the power, 2017-03-17 05:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 05:58:00]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-03-17 06:37:40]

tzik@chromium.org changed reviewers:
+ asanka@chromium.org

[tzik, 2017-03-17 06:43:15]

tzik@chromium.org changed reviewers:
+ treib@chromium.org

[tzik, 2017-03-17 06:44:55]

tzik@chromium.org changed reviewers:
+ xhwang@chromium.org

[tzik, 2017-03-17 06:47:07]

tzik@chromium.org changed reviewers:
+ dpranke@chromium.org

[tzik, 2017-03-17 06:53:13]

PTAL to:
asanka: //chrome/browser/download
treib: //components/ntp_snippets
xhwang: //media
dpranke: //testing

[Marc Treib, 2017-03-17 09:37:46]

ntp_snippets lgtm

[xhwang, 2017-03-17 16:28:53]

media lgtm

[asanka, 2017-03-17 17:11:03]

lgtm

[Dirk Pranke, 2017-03-19 21:06:25]

rs- lgtm

[tzik, 2017-03-20 03:48:08]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-03-20 03:48:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 07:14:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489981688015870, "parent_rev":
"127b4c34e8f23638707ba2ae54fc6f3be3b70ba8", "commit_rev":
"2e53fef9596667824f9f0467fb6b2eabf1eb121e"}

[commit-bot: I haz the power, 2017-03-20 07:15:13]

Description was changed from

==========
Avoid to use the method pointer to Callback<>::Run on gmock tests

This CL replaces a problematic method pointers to Callback::Run with
testing::CreateFunctor.

The method pointer to Callback::Run prevents to make it a template
method or to overload it for cleaner implementation.
==========

to

==========
Avoid to use the method pointer to Callback<>::Run on gmock tests

This CL replaces a problematic method pointers to Callback::Run with
testing::CreateFunctor.

The method pointer to Callback::Run prevents to make it a template
method or to overload it for cleaner implementation.

Review-Url: https://codereview.chromium.org/2758713002
Cr-Commit-Position: refs/heads/master@{#458018}
Committed:
https://chromium.googlesource.com/chromium/src/+/2e53fef9596667824f9f0467fb6b...
==========

[commit-bot: I haz the power, 2017-03-20 07:15:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2e53fef9596667824f9f0467fb6b...