Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2758683004: Match WebUSB specification on use of FrozenArray for attributes. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
scheib
CC:
chromium-reviews, haraken, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match WebUSB specification on use of FrozenArray for attributes. This patch updates the WebUSB IDL files to match the specification in using FrozenArray instead of sequence for attributes as sequence is not allowed in this context. BUG=702585 Review-Url: https://codereview.chromium.org/2758683004 Cr-Commit-Position: refs/heads/master@{#457901} Committed: https://chromium.googlesource.com/chromium/src/+/25e1a52bab34b538d12dfbe40c34e1a168e4b8a6

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
Please take a look.
3 years, 9 months ago (2017-03-17 17:54:02 UTC) #4
scheib
lgtm
3 years, 9 months ago (2017-03-17 22:55:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758683004/1
3 years, 9 months ago (2017-03-17 23:18:43 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 23:26:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25e1a52bab34b538d12dfbe40c34...

Powered by Google App Engine
This is Rietveld 408576698