Chromium Code Reviews
Help | Chromium Project | Sign in
(6)

Issue 2758653003: Implement debug marker entry points in the passthrough command buffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by Geoff Lang
Modified:
1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement debug marker entry points in the passthrough command buffer. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2758653003 Cr-Commit-Position: refs/heads/master@{#458098} Committed: https://chromium.googlesource.com/chromium/src/+/6019ce8862dbf9acbc4b2a6b42849657002f3b41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 chunk +15 lines, -3 lines 0 comments Download
Trybot results:  chromium_presubmit   win_optional_gpu_tests_rel   win_optional_gpu_tests_rel   win_clang   mac_optional_gpu_tests_rel   mac_chromium_compile_dbg_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   mac_chromium_rel_ng   chromeos_daisy_chromium_compile_only_ng   android_optional_gpu_tests_rel   android_n5x_swarming_rel   android_compile_dbg   linux_chromium_rel_ng   linux_optional_gpu_tests_rel   ios-simulator-xcode-clang   ios-device-xcode-clang   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   chromium_presubmit   android_arm64_dbg_recipe   cast_shell_linux   android_clang_dbg_recipe   android_cronet   cast_shell_android   linux_chromium_chromeos_ozone_rel_ng   ios-simulator   linux_chromium_tsan_rel_ng   ios-device   linux_chromium_asan_rel_ng   linux_android_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   android_n5x_swarming_rel   win_chromium_x64_rel_ng   mac_chromium_compile_dbg_ng   win_chromium_compile_dbg_ng   ios-device   win_chromium_rel_ng   linux_chromium_rel_ng   ios-simulator-xcode-clang   linux_optional_gpu_tests_rel   win_optional_gpu_tests_rel   win_clang   mac_chromium_rel_ng   ios-device-xcode-clang   ios-simulator   mac_optional_gpu_tests_rel   linux_chromium_tsan_rel_ng   cast_shell_android   linux_android_rel_ng   linux_chromium_asan_rel_ng   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   android_clang_dbg_recipe   android_n5x_swarming_rel   android_arm64_dbg_recipe   android_cronet   cast_shell_linux   android_optional_gpu_tests_rel   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_daisy_chromium_compile_only_ng   chromium_presubmit   android_compile_dbg 
Commit queue not available (can’t edit this change).

Messages

Total messages: 18 (14 generated)
Geoff Lang
PTAL
1 month ago (2017-03-20 15:22:54 UTC) #12
Zhenyao Mo
On 2017/03/20 15:22:54, Geoff Lang wrote: > PTAL lgtm
1 month ago (2017-03-20 16:48:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758653003/1
1 month ago (2017-03-20 16:51:33 UTC) #15
commit-bot: I haz the power
1 month ago (2017-03-20 16:58:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6019ce8862dbf9acbc4b2a6b4284...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46