Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2758653003: Implement debug marker entry points in the passthrough command buffer. (Closed)

Created:
3 years, 9 months ago by Geoff Lang
Modified:
3 years, 9 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement debug marker entry points in the passthrough command buffer. BUG=602688 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2758653003 Cr-Commit-Position: refs/heads/master@{#458098} Committed: https://chromium.googlesource.com/chromium/src/+/6019ce8862dbf9acbc4b2a6b42849657002f3b41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M gpu/command_buffer/service/feature_info.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Geoff Lang
PTAL
3 years, 9 months ago (2017-03-20 15:22:54 UTC) #12
Zhenyao Mo
On 2017/03/20 15:22:54, Geoff Lang wrote: > PTAL lgtm
3 years, 9 months ago (2017-03-20 16:48:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758653003/1
3 years, 9 months ago (2017-03-20 16:51:33 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 16:58:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6019ce8862dbf9acbc4b2a6b4284...

Powered by Google App Engine
This is Rietveld 408576698