Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2758583002: Remove google-profile-info switch. (Closed)

Created:
3 years, 9 months ago by msarda
Modified:
3 years, 9 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, pam+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove google-profile-info switch. This feature has been shipped for more than a year now. This CL removes this experimental switch and the parts of the code that are now obsolete. BUG=NONE Review-Url: https://codereview.chromium.org/2758583002 Cr-Commit-Position: refs/heads/master@{#457801} Committed: https://chromium.googlesource.com/chromium/src/+/4224a22a5cecb204a7eb05b0117ce7080571d24a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revert histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/profiles/profiles_state.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/signin/core/common/profile_management_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
msarda
Please take a look.
3 years, 9 months ago (2017-03-16 17:33:14 UTC) #4
jochen (gone - plz use gerrit)
lgtm without the histograms.xml change. also there's a typo in the CL description (swi*tch*) https://codereview.chromium.org/2758583002/diff/1/tools/metrics/histograms/histograms.xml ...
3 years, 9 months ago (2017-03-16 19:15:34 UTC) #5
msarda
https://codereview.chromium.org/2758583002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2758583002/diff/1/tools/metrics/histograms/histograms.xml#oldcode99297 tools/metrics/histograms/histograms.xml:99297: - <int value="-254887599" label="google-profile-info"/> On 2017/03/16 19:15:34, jochen wrote: ...
3 years, 9 months ago (2017-03-17 16:16:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758583002/20001
3 years, 9 months ago (2017-03-17 16:16:44 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 17:21:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4224a22a5cecb204a7eb05b0117c...

Powered by Google App Engine
This is Rietveld 408576698