Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2758573002: Avoid to call KeyboardController::ResetInstance twice (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, sadrul, jam, darin-cc_chromium.org, oka+watchvk_chromium.org, yhanada+watchvk_chromium.org, kalyank, dfaden+virtualkb_google.com, groby+virtualkb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid to call KeyboardController::ResetInstance twice Removed KeyboardController::ResetInstance(nullptr) in ~Shell because it should have been called already in DeactivateKeyboard. BUG=None TEST=try Review-Url: https://codereview.chromium.org/2758573002 Cr-Commit-Position: refs/heads/master@{#458240} Committed: https://chromium.googlesource.com/chromium/src/+/70c46acd7f5117902acf57801960abc64e314825

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ash/shell.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
oka
PTAL.
3 years, 9 months ago (2017-03-16 15:40:26 UTC) #6
oshima
lgtm
3 years, 9 months ago (2017-03-16 18:54:39 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 2747373006 Patch 1). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-17 08:07:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758573002/20001
3 years, 9 months ago (2017-03-20 22:52:14 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 23:40:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/70c46acd7f5117902acf57801960...

Powered by Google App Engine
This is Rietveld 408576698