Keep focused device in Bluetooth device list when the list is refreshed.

Keep focused device in Bluetooth device list when the list is refreshed.

When the Bluetooth device list is updated, child views on the scroll_content
were removed and the focused view was resed.
We should remember the focused device before remove the children, and re-focus
the device after we create the new list.

BUG=673048
TEST=manually tested

Review-Url: https://codereview.chromium.org/2758553002
Cr-Commit-Position: refs/heads/master@{#457666}
Committed: https://chromium.googlesource.com/chromium/src/+/d10bb36641de2636f34292c0e626a7202ff674bb

[fukino, 2017-03-16 14:20:14]

fukino@chromium.org changed reviewers:
+ tdanderson@chromium.org

[fukino, 2017-03-16 14:20:15]

Terry, could you take a look?

This should fix the issue mentioned in
https://bugs.chromium.org/p/chromium/issues/detail?id=673048#c19
"every time we update the list of Bluetooth devices, we lose focus and it resets
to the top of the Bluetooth subpage."

However, the orange focus outline drawn by Chromevox is still weird. I suppose
it is an independent problem we can fix separately.

https://codereview.chromium.org/2758553002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/bluetooth/tray_bluetooth.cc (right):

https://codereview.chromium.org/2758553002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/bluetooth/tray_bluetooth.cc:325:
FocusDeviceByAddress(focused_device_address);
Here, I restore the focus based on the device address rather than index in the
list.
I believe this is better considering the case when the list is long and the
number of upper items from the focused item changes.
However, when the focused item disappears from the list, the focus will be
reset. I assume it is a rare case, but WDYT?

[tdanderson, 2017-03-16 20:40:14]

Thanks for coming back to this, LGTM.

https://codereview.chromium.org/2758553002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/bluetooth/tray_bluetooth.cc (right):

https://codereview.chromium.org/2758553002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/bluetooth/tray_bluetooth.cc:325:
FocusDeviceByAddress(focused_device_address);
On 2017/03/16 14:20:15, fukino wrote:
> Here, I restore the focus based on the device address rather than index in the
> list.
> I believe this is better considering the case when the list is long and the
> number of upper items from the focused item changes.
> However, when the focused item disappears from the list, the focus will be
> reset. I assume it is a rare case, but WDYT?

Sounds good to me, I think focusing based on address is the right way to do it.
And if the focused element disappears, then I think resetting focus is perfectly
reasonable.

[fukino, 2017-03-17 02:22:53]

Thank you for the review!

[fukino, 2017-03-17 02:22:58]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:23:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:55:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489717378440580, "parent_rev":
"4089977fdebad10fac160d2a43d65b97f00d92ab", "commit_rev":
"d10bb36641de2636f34292c0e626a7202ff674bb"}

[commit-bot: I haz the power, 2017-03-17 02:56:36]

Description was changed from

==========
Keep focused device in Bluetooth device list when the list is refreshed.

When the Bluetooth device list is updated, child views on the scroll_content
were removed and the focused view was resed.
We should remember the focused device before remove the children, and re-focus
the device after we create the new list.

BUG=673048
TEST=manually tested
==========

to

==========
Keep focused device in Bluetooth device list when the list is refreshed.

When the Bluetooth device list is updated, child views on the scroll_content
were removed and the focused view was resed.
We should remember the focused device before remove the children, and re-focus
the device after we create the new list.

BUG=673048
TEST=manually tested

Review-Url: https://codereview.chromium.org/2758553002
Cr-Commit-Position: refs/heads/master@{#457666}
Committed:
https://chromium.googlesource.com/chromium/src/+/d10bb36641de2636f34292c0e626...
==========

[commit-bot: I haz the power, 2017-03-17 02:56:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d10bb36641de2636f34292c0e626...