Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2758523002:
Remove unused variable declaration. (Closed)
DescriptionRemove unused variable declaration.
Remove declaration of FLAGS_use_http2_frame_decoder_adapter from spdy_flags.h
which is never used in the codebase, see [1]. Instead,
FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter is used
everywhere.
[1] https://cs.chromium.org/search/?q=FLAGS_use_http2_frame_decoder_adapter&ssfr=1&type=cs
Review-Url: https://codereview.chromium.org/2758523002
Cr-Commit-Position: refs/heads/master@{#457529}
Committed: https://chromium.googlesource.com/chromium/src/+/172041b141cf59b4fc2fe8f4e675f0a63cd2a08f
Patch Set 1 #Patch Set 2 : Remove accidentally added file. #Patch Set 3 : Rebase. #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by bnc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bnc@chromium.org changed reviewers: + xunjieli@chromium.org
xunjieli: PTAL. Thanks.
On 2017/03/16 13:41:10, Bence wrote: > xunjieli: PTAL. Thanks. Is "output" added accidentally? the rest lgtm
On 2017/03/16 16:46:42, xunjieli wrote: > On 2017/03/16 13:41:10, Bence wrote: > > xunjieli: PTAL. Thanks. > > Is "output" added accidentally? the rest lgtm Oops. Sorry.
The CQ bit was checked by bnc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xunjieli@chromium.org Link to the patchset: https://codereview.chromium.org/2758523002/#ps20001 (title: "Remove accidentally added file.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for net/spdy/spdy_flags.h:
While running git apply --index -p1;
error: patch failed: net/spdy/spdy_flags.h:15
error: net/spdy/spdy_flags.h: patch does not apply
Patch: net/spdy/spdy_flags.h
Index: net/spdy/spdy_flags.h
diff --git a/net/spdy/spdy_flags.h b/net/spdy/spdy_flags.h
index
a660235bf4974486ad40dc7d42a84fbf58c1e6b6..ad18c6ef8f94ab35fe2db56dfdeaf4d1a722f10b
100644
--- a/net/spdy/spdy_flags.h
+++ b/net/spdy/spdy_flags.h
@@ -15,7 +15,6 @@ NET_EXPORT_PRIVATE extern bool
FLAGS_chromium_http2_flag_spdy_use_hpack_decoder2;
NET_EXPORT_PRIVATE extern bool
FLAGS_chromium_http2_flag_spdy_use_hpack_decoder3;
-NET_EXPORT_PRIVATE extern bool FLAGS_use_http2_frame_decoder_adapter;
NET_EXPORT_PRIVATE extern bool FLAGS_use_nested_spdy_framer_decoder;
NET_EXPORT_PRIVATE extern bool
FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter;
The CQ bit was checked by bnc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from xunjieli@chromium.org Link to the patchset: https://codereview.chromium.org/2758523002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489689919613670,
"parent_rev": "21fe8132924302ea1d830c3df055725cd9efeb8b", "commit_rev":
"172041b141cf59b4fc2fe8f4e675f0a63cd2a08f"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused variable declaration. Remove declaration of FLAGS_use_http2_frame_decoder_adapter from spdy_flags.h which is never used in the codebase, see [1]. Instead, FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter is used everywhere. [1] https://cs.chromium.org/search/?q=FLAGS_use_http2_frame_decoder_adapter&ssfr=... ========== to ========== Remove unused variable declaration. Remove declaration of FLAGS_use_http2_frame_decoder_adapter from spdy_flags.h which is never used in the codebase, see [1]. Instead, FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter is used everywhere. [1] https://cs.chromium.org/search/?q=FLAGS_use_http2_frame_decoder_adapter&ssfr=... Review-Url: https://codereview.chromium.org/2758523002 Cr-Commit-Position: refs/heads/master@{#457529} Committed: https://chromium.googlesource.com/chromium/src/+/172041b141cf59b4fc2fe8f4e675... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/172041b141cf59b4fc2fe8f4e675... |
