Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2758453002: Remove pre-MD code from TrayItemView. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD code from TrayItemView. and MultiProfileMediaTrayView BUG=687809 Review-Url: https://codereview.chromium.org/2758453002 Cr-Commit-Position: refs/heads/master@{#457912} Committed: https://chromium.googlesource.com/chromium/src/+/e2827154a7f84462ecad9a9319032f1baa127786

Patch Set 1 #

Total comments: 1

Patch Set 2 : bonus round #

Messages

Total messages: 19 (13 generated)
Evan Stade
3 years, 9 months ago (2017-03-16 01:20:25 UTC) #3
tdanderson
LGTM https://codereview.chromium.org/2758453002/diff/1/ash/common/system/tray/tray_item_view.cc File ash/common/system/tray/tray_item_view.cc (left): https://codereview.chromium.org/2758453002/diff/1/ash/common/system/tray/tray_item_view.cc#oldcode102 ash/common/system/tray/tray_item_view.cc:102: size.set_height(kTrayIconHeight); note: kTrayIconHeight and kTrayIconWidth are now unused ...
3 years, 9 months ago (2017-03-16 18:01:29 UTC) #7
Evan Stade
found some more old cruft to clear away, PTAL
3 years, 9 months ago (2017-03-17 14:33:47 UTC) #11
tdanderson
Patch set 2 lgtm
3 years, 9 months ago (2017-03-17 17:55:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758453002/20001
3 years, 9 months ago (2017-03-18 00:52:43 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 00:59:42 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2827154a7f84462ecad9a931903...

Powered by Google App Engine
This is Rietveld 408576698