chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html - Issue 2758443003: Remove usb option from manual printer configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2758443003: Remove usb option from manual printer configuration. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

index f80c347472ee61fd837afec177c0acfa0eada75f..0517ba187deceb5382882870ce06978c9ac74f92 100644

--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

@@ -173,7 +173,6 @@

<option value="socket">$i18n{printerProtocolAppSocket}

</option>

<option value="lpd">$i18n{printerProtocolLpd}</option>

- <option value="usb">$i18n{printerProtocolUsb}</option>

xdai1 2017/03/17 03:39:49 drive-by comment: I think you should also remove I

stevenjb 2017/03/17 16:55:11 That would be correct.

skau 2017/03/17 19:52:40 No, it's still used on the printer detail page. h

</select>

</div>

« no previous file with comments | « no previous file | no next file » | no next file with comments »