Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2758443003: Remove usb option from manual printer configuration. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/md_select_css.html"> 1 <link rel="import" href="chrome://resources/html/md_select_css.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html"> 3 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-spinner/paper-spi nner.html">
7 <link rel="import" href="../i18n_setup.html"> 7 <link rel="import" href="../i18n_setup.html">
8 <link rel="import" href="cups_add_printer_dialog_util.html"> 8 <link rel="import" href="cups_add_printer_dialog_util.html">
9 <link rel="import" href="cups_printers_browser_proxy.html"> 9 <link rel="import" href="cups_printers_browser_proxy.html">
10 <link rel="import" href="../settings_shared_css.html"> 10 <link rel="import" href="../settings_shared_css.html">
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 <select class="md-select" 166 <select class="md-select"
167 value="[[newPrinter.printerProtocol]]" 167 value="[[newPrinter.printerProtocol]]"
168 on-change="onProtocolChange_"> 168 on-change="onProtocolChange_">
169 <option value="ipp">$i18n{printerProtocolIpp}</option> 169 <option value="ipp">$i18n{printerProtocolIpp}</option>
170 <option value="ipps">$i18n{printerProtocolIpps}</option> 170 <option value="ipps">$i18n{printerProtocolIpps}</option>
171 <option value="http">$i18n{printerProtocolHttp}</option> 171 <option value="http">$i18n{printerProtocolHttp}</option>
172 <option value="https">$i18n{printerProtocolHttps}</option> 172 <option value="https">$i18n{printerProtocolHttps}</option>
173 <option value="socket">$i18n{printerProtocolAppSocket} 173 <option value="socket">$i18n{printerProtocolAppSocket}
174 </option> 174 </option>
175 <option value="lpd">$i18n{printerProtocolLpd}</option> 175 <option value="lpd">$i18n{printerProtocolLpd}</option>
176 <option value="usb">$i18n{printerProtocolUsb}</option>
xdai1 2017/03/17 03:39:49 drive-by comment: I think you should also remove I
stevenjb 2017/03/17 16:55:11 That would be correct.
skau 2017/03/17 19:52:40 No, it's still used on the printer detail page. h
177 </select> 176 </select>
178 <span class="md-select-underline"></span> 177 <span class="md-select-underline"></span>
179 </div> 178 </div>
180 </div> 179 </div>
181 </div> 180 </div>
182 </div> 181 </div>
183 <div class="settings-box two-line"> 182 <div class="settings-box two-line">
184 <div class="start"> 183 <div class="start">
185 <div class="label">$i18n{printerQueue}</div> 184 <div class="label">$i18n{printerQueue}</div>
186 <div class="secondary"> 185 <div class="secondary">
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 <!-- Manufacturer and Model Dialog --> 369 <!-- Manufacturer and Model Dialog -->
371 <template is="dom-if" if="[[showManufacturerDialog_]]" restamp> 370 <template is="dom-if" if="[[showManufacturerDialog_]]" restamp>
372 <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}" 371 <add-printer-manufacturer-model-dialog new-printer="{{newPrinter}}"
373 setup-failed="[[setupFailed]]"> 372 setup-failed="[[setupFailed]]">
374 </add-printer-manufacturer-model-dialog> 373 </add-printer-manufacturer-model-dialog>
375 </template> 374 </template>
376 375
377 </template> 376 </template>
378 <script src="cups_add_printer_dialog.js"></script> 377 <script src="cups_add_printer_dialog.js"></script>
379 </dom-module> 378 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698