Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2758433002: Remove pre-MD code from SystemTrayBubble. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove pre-MD code from SystemTrayBubble. Delete TrayPopupItemContainer class, which was only used for adding a hover effect that we don't want/use in MD. BUG=687802 Review-Url: https://codereview.chromium.org/2758433002 Cr-Commit-Position: refs/heads/master@{#457462} Committed: https://chromium.googlesource.com/chromium/src/+/992fa8feb97734b7f1facce0cd5feffbb98d15f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -158 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/audio/volume_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/tray/system_tray_bubble.cc View 4 chunks +4 lines, -29 lines 0 comments Download
M ash/common/system/tray/system_tray_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ash/common/system/tray/tray_popup_item_container.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ash/common/system/tray/tray_popup_item_container.cc View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Evan Stade
3 years, 9 months ago (2017-03-16 00:26:29 UTC) #3
James Cook
Code LGTM but see email thread where we're considering adding back some kind of hover ...
3 years, 9 months ago (2017-03-16 16:06:02 UTC) #7
Evan Stade
On 2017/03/16 16:06:02, James Cook wrote: > Code LGTM but see email thread where we're ...
3 years, 9 months ago (2017-03-16 16:57:36 UTC) #8
James Cook
On 2017/03/16 16:57:36, Evan Stade wrote: > On 2017/03/16 16:06:02, James Cook wrote: > > ...
3 years, 9 months ago (2017-03-16 17:02:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758433002/1
3 years, 9 months ago (2017-03-16 17:03:25 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:09:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/992fa8feb97734b7f1facce0cd5f...

Powered by Google App Engine
This is Rietveld 408576698