[turbofan] Inline String.prototype.concat with PlainPrimitive parameter.

[turbofan] Inline String.prototype.concat with PlainPrimitive parameter.

When we hit a call to String.prototype.concat builtin, where we can
infer that the receiver is a String and there's exactly one parameter,
which is of type PlainPrimitive, then we can reduce that to a call to
the StringAddStub instead, optionally converting the non-String - but
PlainPrimitive - parameter to a String.

BUG=v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2758383002
Cr-Commit-Position: refs/heads/master@{#43957}
Committed: https://chromium.googlesource.com/v8/v8/+/f08c3fd324c8cd5d1305a5a3de3b2ce0e242ff67

[Benedikt Meurer, 2017-03-20 18:24:10]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:24:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-03-20 18:25:55]

Hey Jaro,

Here's some simple lowering I did some time ago for one of the Speedometer line
items. Seems to help a bit now that we optimize more; main cost related to this
seems to be the compilation of the concat builtin itself, porting to CSA seems
beneficial (separate CL).
Please take a look.

Thanks,
Benedikt

[commit-bot: I haz the power, 2017-03-20 18:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 18:41:37]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Benedikt Meurer, 2017-03-20 19:05:20]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:16:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/22946)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[Benedikt Meurer, 2017-03-20 19:23:20]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 19:23:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2017-03-20 20:23:16]

On 2017/03/20 18:25:55, Benedikt Meurer wrote:
> Hey Jaro,
> 
> Here's some simple lowering I did some time ago for one of the Speedometer
line
> items. Seems to help a bit now that we optimize more; main cost related to
this
> seems to be the compilation of the concat builtin itself, porting to CSA seems
> beneficial (separate CL).
> Please take a look.
> 
> Thanks,
> Benedikt

lgtm, but could you be more specific about where exactly it helps?

[commit-bot: I haz the power, 2017-03-20 20:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:31:53]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-03-20 20:34:50]

On 2017/03/20 20:23:16, Jarin wrote:
> On 2017/03/20 18:25:55, Benedikt Meurer wrote:
> > Hey Jaro,
> > 
> > Here's some simple lowering I did some time ago for one of the Speedometer
> line
> > items. Seems to help a bit now that we optimize more; main cost related to
> this
> > seems to be the compilation of the concat builtin itself, porting to CSA
seems
> > beneficial (separate CL).
> > Please take a look.
> > 
> > Thanks,
> > Benedikt
> 
> lgtm, but could you be more specific about where exactly it helps?

Ember, React and FlightJS.

[Benedikt Meurer, 2017-03-20 20:35:26]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 20:37:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490042126725540,
"parent_rev": "de04df74129bba5539c6b887a2d2c81015fff866", "commit_rev":
"f08c3fd324c8cd5d1305a5a3de3b2ce0e242ff67"}

[commit-bot: I haz the power, 2017-03-20 20:37:14]

Description was changed from

==========
[turbofan] Inline String.prototype.concat with PlainPrimitive parameter.

When we hit a call to String.prototype.concat builtin, where we can
infer that the receiver is a String and there's exactly one parameter,
which is of type PlainPrimitive, then we can reduce that to a call to
the StringAddStub instead, optionally converting the non-String - but
PlainPrimitive - parameter to a String.

BUG=v8:5267
R=jarin@chromium.org
==========

to

==========
[turbofan] Inline String.prototype.concat with PlainPrimitive parameter.

When we hit a call to String.prototype.concat builtin, where we can
infer that the receiver is a String and there's exactly one parameter,
which is of type PlainPrimitive, then we can reduce that to a call to
the StringAddStub instead, optionally converting the non-String - but
PlainPrimitive - parameter to a String.

BUG=v8:5267
R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2758383002
Cr-Commit-Position: refs/heads/master@{#43957}
Committed:
https://chromium.googlesource.com/v8/v8/+/f08c3fd324c8cd5d1305a5a3de3b2ce0e24...
==========

[commit-bot: I haz the power, 2017-03-20 20:37:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f08c3fd324c8cd5d1305a5a3de3b2ce0e24...