Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2758383002: [turbofan] Inline String.prototype.concat with PlainPrimitive parameter. (Closed)

Created:
3 years, 9 months ago by Benedikt Meurer
Modified:
3 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline String.prototype.concat with PlainPrimitive parameter. When we hit a call to String.prototype.concat builtin, where we can infer that the receiver is a String and there's exactly one parameter, which is of type PlainPrimitive, then we can reduce that to a call to the StringAddStub instead, optionally converting the non-String - but PlainPrimitive - parameter to a String. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2758383002 Cr-Commit-Position: refs/heads/master@{#43957} Committed: https://chromium.googlesource.com/v8/v8/+/f08c3fd324c8cd5d1305a5a3de3b2ce0e242ff67

Patch Set 1 #

Patch Set 2 : Actually use the receiver. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Benedikt Meurer
3 years, 9 months ago (2017-03-20 18:24:09 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some simple lowering I did some time ago for one of the ...
3 years, 9 months ago (2017-03-20 18:25:55 UTC) #4
Jarin
On 2017/03/20 18:25:55, Benedikt Meurer wrote: > Hey Jaro, > > Here's some simple lowering ...
3 years, 9 months ago (2017-03-20 20:23:16 UTC) #13
Benedikt Meurer
On 2017/03/20 20:23:16, Jarin wrote: > On 2017/03/20 18:25:55, Benedikt Meurer wrote: > > Hey ...
3 years, 9 months ago (2017-03-20 20:34:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758383002/20001
3 years, 9 months ago (2017-03-20 20:35:31 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 20:37:15 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f08c3fd324c8cd5d1305a5a3de3b2ce0e24...

Powered by Google App Engine
This is Rietveld 408576698