Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2758353002: Deprecate the StickyDefaultBrowserPrompt experiment (Closed)

Created:
3 years, 9 months ago by Patrick Monette
Modified:
3 years, 9 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate the StickyDefaultBrowserPrompt experiment Removed the tests since they are now pointless. BUG=619145 Review-Url: https://codereview.chromium.org/2758353002 Cr-Commit-Position: refs/heads/master@{#458256} Committed: https://chromium.googlesource.com/chromium/src/+/01b428d402dcc8edc641c1442315f999dffbcb63

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -208 lines) Patch
M chrome/browser/ui/startup/default_browser_infobar_delegate.h View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/startup/default_browser_infobar_delegate.cc View 1 2 chunks +4 lines, -39 lines 0 comments Download
D chrome/browser/ui/startup/default_browser_infobar_delegate_unittest.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Patrick Monette
PTAL. Cleaning up an old experiment.
3 years, 9 months ago (2017-03-20 17:42:31 UTC) #3
Peter Kasting
LGTM https://codereview.chromium.org/2758353002/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc File chrome/browser/ui/startup/default_browser_infobar_delegate.cc (right): https://codereview.chromium.org/2758353002/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc#newcode20 chrome/browser/ui/startup/default_browser_infobar_delegate.cc:20: #include "base/win/windows_version.h" I bet this #include can go ...
3 years, 9 months ago (2017-03-20 20:13:03 UTC) #4
Patrick Monette
Thanks! https://codereview.chromium.org/2758353002/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc File chrome/browser/ui/startup/default_browser_infobar_delegate.cc (right): https://codereview.chromium.org/2758353002/diff/1/chrome/browser/ui/startup/default_browser_infobar_delegate.cc#newcode20 chrome/browser/ui/startup/default_browser_infobar_delegate.cc:20: #include "base/win/windows_version.h" On 2017/03/20 20:13:03, Peter Kasting wrote: ...
3 years, 9 months ago (2017-03-20 20:25:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758353002/20001
3 years, 9 months ago (2017-03-20 20:26:56 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 00:39:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/01b428d402dcc8edc641c1442315...

Powered by Google App Engine
This is Rietveld 408576698