Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/android/java/res/layout/picker_bitmap_view.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)
Patch Set: Polish Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/picker_bitmap_view.xml
diff --git a/chrome/android/java/res/layout/picker_bitmap_view.xml b/chrome/android/java/res/layout/picker_bitmap_view.xml
new file mode 100644
index 0000000000000000000000000000000000000000..028a184ddbf45c4973cbc40820af4e525306ddaf
--- /dev/null
+++ b/chrome/android/java/res/layout/picker_bitmap_view.xml
@@ -0,0 +1,77 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ Copyright 2016 The Chromium Authors. All rights reserved.
Theresa 2017/03/21 15:37:00 s/2016/2017
Finnur 2017/03/27 16:50:42 Done.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<!-- Represents a single item in the DownloadHistoryAdapterView. -->
Theresa 2017/03/21 15:37:00 This comment needs to be updated.
Finnur 2017/03/27 16:50:41 Done.
+
+<view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView"
+ xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:background="@color/file_picker_tile_bg_color">
+
+ <!-- android:background="?android:attr/selectableItemBackground" -->
Theresa 2017/03/21 15:37:00 Remove this left over comment
Finnur 2017/03/27 16:50:41 Done.
+ <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
Theresa 2017/03/21 15:37:00 xmlns doesn't need to be defined twice
Finnur 2017/03/27 16:50:41 Done.
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:focusable="true"
+ android:orientation="vertical">
+
+ <FrameLayout
+ android:id="@+id/border"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content">
+
+ <ImageView
+ android:id="@+id/bitmap_view"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:contentDescription="@null" />
+
+ <View
+ android:id="@+id/scrim"
+ android:layout_width="64dp"
+ android:layout_height="64dp"
+ android:background="@drawable/file_picker_scrim"
+ android:visibility="gone" />
+ </FrameLayout>
+
+ <ImageView
+ android:id="@+id/selected"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginStart="4dp"
+ android:layout_marginTop="4dp"
+ android:background="@drawable/file_picker_selected_background"
+ android:elevation="2dp"
+ android:contentDescription="@string/clear_cookies_and_site_data_title"
+ android:visibility="gone" />
+ <ImageView
+ android:id="@+id/unselected"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_marginStart="4dp"
+ android:layout_marginTop="4dp"
+ android:contentDescription="@string/clear_cookies_and_site_data_title"
+ android:visibility="gone" />
+
+ <!-- Special tiles, that give access to the camera and gallery -->
+ <TextView
+ android:id="@+id/special_tile"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="@dimen/file_picker_label_gap"
+ android:drawablePadding="10dp"
+ android:fontFamily="sans-serif-medium"
+ android:textStyle="bold"
+ android:textSize="14sp"
+ android:textAllCaps="true"
+ android:textColor="@color/file_picker_special_tile_color"
+ android:gravity="center"
+ android:layout_centerInParent="true" />
+
+ </RelativeLayout>
+</view>

Powered by Google App Engine
This is Rietveld 408576698