chrome/android/java/res/layout/picker_bitmap_view.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff: chrome/android/java/res/layout/picker_bitmap_view.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Polish Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/android/java/res/layout/photo_picker_dialog_title.xml ('K') | « chrome/android/java/res/layout/photo_picker_dialog_title.xml ('k') | chrome/android/java/res/layout/picker_category_view.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2016 The Chromium Authors. All rights reserved.
	Theresa 2017/03/21 15:37:00 s/2016/2017 s/2016/2017 Finnur 2017/03/27 16:50:42 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > s/2016/2017 Done.
	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <!-- Represents a single item in the DownloadHistoryAdapterView. -->
	Theresa 2017/03/21 15:37:00 This comment needs to be updated. This comment needs to be updated. Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > This comment needs to be updated. Done.
	9

	10 <view class="org.chromium.chrome.browser.photo_picker.PickerBitmapView"

	11 xmlns:android="http://schemas.android.com/apk/res/android"

	12 android:layout_width="wrap_content"

	13 android:layout_height="wrap_content"

	14 android:background="@color/file_picker_tile_bg_color">

	15

	16 <!-- android:background="?android:attr/selectableItemBackground" -->
	Theresa 2017/03/21 15:37:00 Remove this left over comment Remove this left over comment Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > Remove this left over comment Done.
	17 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
	Theresa 2017/03/21 15:37:00 xmlns doesn't need to be defined twice xmlns doesn't need to be defined twice Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > xmlns doesn't need to be defined twice Done.
	18 android:layout_width="wrap_content"

	19 android:layout_height="wrap_content"

	20 android:focusable="true"

	21 android:orientation="vertical">

	22

	23 <FrameLayout

	24 android:id="@+id/border"

	25 android:layout_width="wrap_content"

	26 android:layout_height="wrap_content">

	27

	28 <ImageView

	29 android:id="@+id/bitmap_view"

	30 android:layout_width="wrap_content"

	31 android:layout_height="wrap_content"

	32 android:contentDescription="@null" />

	33

	34 <View

	35 android:id="@+id/scrim"

	36 android:layout_width="64dp"

	37 android:layout_height="64dp"

	38 android:background="@drawable/file_picker_scrim"

	39 android:visibility="gone" />

	40 </FrameLayout>

	41

	42 <ImageView

	43 android:id="@+id/selected"

	44 android:layout_width="wrap_content"

	45 android:layout_height="wrap_content"

	46 android:layout_marginStart="4dp"

	47 android:layout_marginTop="4dp"

	48 android:background="@drawable/file_picker_selected_background"

	49 android:elevation="2dp"

	50 android:contentDescription="@string/clear_cookies_and_site_data_titl e"

	51 android:visibility="gone" />

	52 <ImageView

	53 android:id="@+id/unselected"

	54 android:layout_width="wrap_content"

	55 android:layout_height="wrap_content"

	56 android:layout_marginStart="4dp"

	57 android:layout_marginTop="4dp"

	58 android:contentDescription="@string/clear_cookies_and_site_data_titl e"

	59 android:visibility="gone" />

	60

	61 <!-- Special tiles, that give access to the camera and gallery -->

	62 <TextView

	63 android:id="@+id/special_tile"

	64 android:layout_width="match_parent"

	65 android:layout_height="wrap_content"

	66 android:layout_marginTop="@dimen/file_picker_label_gap"

	67 android:drawablePadding="10dp"

	68 android:fontFamily="sans-serif-medium"

	69 android:textStyle="bold"

	70 android:textSize="14sp"

	71 android:textAllCaps="true"

	72 android:textColor="@color/file_picker_special_tile_color"

	73 android:gravity="center"

	74 android:layout_centerInParent="true" />

	75

	76 </RelativeLayout>

	77 </view>

OLD	NEW