Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5189)

Unified Diff: chrome/android/java/res/layout/bitmap_list_row.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)
Patch Set: Polish Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/bitmap_list_row.xml
diff --git a/chrome/android/java/res/layout/bitmap_list_row.xml b/chrome/android/java/res/layout/bitmap_list_row.xml
new file mode 100644
index 0000000000000000000000000000000000000000..9ef7b14c9ff9ffcef339ff5dfc34517a5c0a48c4
--- /dev/null
+++ b/chrome/android/java/res/layout/bitmap_list_row.xml
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+ Copyright 2016 The Chromium Authors. All rights reserved.
Theresa 2017/03/21 15:37:00 s/2016/2017
Finnur 2017/03/27 16:50:41 Done.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:focusable="true"
+ android:clickable="true"
+ android:gravity="center"
+ android:background="?android:attr/selectableItemBackground"
+ android:orientation="vertical">
+
+ <ImageView
+ android:id="@+id/bitmap"
+ android:layout_width="match_parent"
+ android:layout_height="match_parent"
+ android:contentDescription="@string/clear_cookies_and_site_data_title"
Theresa 2017/03/21 15:37:00 This string is just a placeholder, right? Will you
Finnur 2017/03/27 16:50:41 Not really a placeholder. I used another string to
+ android:scaleType="centerCrop" />
+
+ <ImageView
+ android:id="@+id/selected"
Theresa 2017/03/21 15:36:59 Is this for the selected background? If so, select
Finnur 2017/03/27 16:50:41 Done.
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingStart="10dp"
+ android:paddingTop="10dp"
+ android:contentDescription="@string/clear_cookies_and_site_data_title"
+ android:visibility="gone" />
+ <ImageView
Theresa 2017/03/21 15:37:00 nit: blank line before this ImageView
Finnur 2017/03/27 16:50:41 Done.
+ android:id="@+id/unselected"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingStart="10dp"
+ android:paddingTop="10dp"
+ android:contentDescription="@string/clear_cookies_and_site_data_title"
+ android:visibility="gone" />
+
+</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698