chrome/android/java/res/layout/bitmap_list_row.xml - Issue 2758313002: Implement the new Photo picker, part two.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/bitmap_list_row.xml

Issue 2758313002: Implement the new Photo picker, part two. (Closed)

Patch Set: Polish Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/drawable/file_picker_selected_background.xml ('K') | « chrome/android/java/res/drawable/file_picker_selected_background.xml ('k') | chrome/android/java/res/layout/photo_picker_dialog_content.xml » ('j') | chrome/android/java/res/layout/photo_picker_dialog_content.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!--

	3 Copyright 2016 The Chromium Authors. All rights reserved.
	Theresa 2017/03/21 15:37:00 s/2016/2017 s/2016/2017 Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > s/2016/2017 Done.
	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 android:focusable="true"

	12 android:clickable="true"

	13 android:gravity="center"

	14 android:background="?android:attr/selectableItemBackground"

	15 android:orientation="vertical">

	16

	17 <ImageView

	18 android:id="@+id/bitmap"

	19 android:layout_width="match_parent"

	20 android:layout_height="match_parent"

	21 android:contentDescription="@string/clear_cookies_and_site_data_title"
	Theresa 2017/03/21 15:37:00 This string is just a placeholder, right? Will you This string is just a placeholder, right? Will you please add a TODO to update these strings or remove this file (whatever the next step is). Finnur 2017/03/27 16:50:41 Not really a placeholder. I used another string to Not really a placeholder. I used another string to get around a lint error somewhere, as I didn't think of @null. Meant to get back to it, but forgot.
	22 android:scaleType="centerCrop" />

	23

	24 <ImageView

	25 android:id="@+id/selected"
	Theresa 2017/03/21 15:36:59 Is this for the selected background? If so, select Is this for the selected background? If so, selected_bg or selected_background would be a good id, and the content description can be @null. Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:36:59, Theresa wrote: > Is this for the selected background? If so, selected_bg or selected_background > would be a good id, and the content description can be @null. Done.
	26 android:layout_width="wrap_content"

	27 android:layout_height="wrap_content"

	28 android:paddingStart="10dp"

	29 android:paddingTop="10dp"

	30 android:contentDescription="@string/clear_cookies_and_site_data_title"

	31 android:visibility="gone" />

	32 <ImageView
	Theresa 2017/03/21 15:37:00 nit: blank line before this ImageView nit: blank line before this ImageView Finnur 2017/03/27 16:50:41 Done. Show quoted text On 2017/03/21 15:37:00, Theresa wrote: > nit: blank line before this ImageView Done.
	33 android:id="@+id/unselected"

	34 android:layout_width="wrap_content"

	35 android:layout_height="wrap_content"

	36 android:paddingStart="10dp"

	37 android:paddingTop="10dp"

	38 android:contentDescription="@string/clear_cookies_and_site_data_title"

	39 android:visibility="gone" />

	40

	41 </RelativeLayout>

OLD	NEW