Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG=703254
TEST=gpu_unittests
R=bsalomon@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2758173003
Cr-Commit-Position: refs/heads/master@{#458220}
Committed: https://chromium.googlesource.com/chromium/src/+/9b5537f92d5910a563811ce14208d7cb8b45b377

[Zhenyao Mo, 2017-03-20 18:26:16]

Description was changed from

==========
Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG=703254
TEST=gpu_unittests
R=bsalomon@chromium.org
==========

to

==========
Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG=703254
TEST=gpu_unittests
R=bsalomon@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2017-03-20 18:26:27]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:26:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2017-03-20 18:27:56]

Brian: PTAL

https://codereview.chromium.org/2758173003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (left):

https://codereview.chromium.org/2758173003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:12374: case GL_RENDERER:
Note we remove the special handling, and they just default to the glGetString()
below.

[bsalomon, 2017-03-20 18:54:54]

bsalomon@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2017-03-20 18:54:54]

Looks like a unit test needs updating. lgtm from Skia's point of view, though.

[commit-bot: I haz the power, 2017-03-20 19:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:12:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2017-03-20 20:15:38]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2017-03-20 20:15:39]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2758173003/#ps20001
(title: "Fixing gl_tests")

[commit-bot: I haz the power, 2017-03-20 20:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 20:16:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 20:16:39]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Zhenyao Mo, 2017-03-20 20:26:03]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2017-03-20 20:26:20]

Brian, can you review using your chromium account?

[commit-bot: I haz the power, 2017-03-20 20:27:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2017-03-20 21:15:49]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2017-03-20 21:15:50]

lgtm to unblock this.

[commit-bot: I haz the power, 2017-03-20 21:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:36:32]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2017-03-20 21:49:14]

On 2017/03/20 21:15:50, Ken Russell wrote:
> lgtm to unblock this.

Thanks Ken

[Zhenyao Mo, 2017-03-20 21:49:18]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2017-03-20 21:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 23:02:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490046558339000,
"parent_rev": "183db682fc5fb82cc837474c245cb6acab56f0fe", "commit_rev":
"9b5537f92d5910a563811ce14208d7cb8b45b377"}

[commit-bot: I haz the power, 2017-03-20 23:19:56]

Description was changed from

==========
Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG=703254
TEST=gpu_unittests
R=bsalomon@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Expose GL_VENDOR/GL_RENDERER strings to internal clients of GPU command buffer.

BUG=703254
TEST=gpu_unittests
R=bsalomon@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2758173003
Cr-Commit-Position: refs/heads/master@{#458220}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b5537f92d5910a563811ce14208...
==========

[commit-bot: I haz the power, 2017-03-20 23:19:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b5537f92d5910a563811ce14208...

[bsalomon_chromium, 2017-03-21 13:18:16]

On 2017/03/20 20:26:20, Zhenyao Mo wrote:
> Brian, can you review using your chromium account?

lgtm. Sorry about that, Mo.