Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2758163004: gpu: Remove some ipc code no longer used. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by sadrul
Modified:
4 months, 1 week ago
Reviewers:
Tom Sepez, jbauman, piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove some ipc code no longer used. Some traits and structs are no longer used after the chrome ipc messages have been replaced by corresponding mojom api. Remove them. BUG=none TBR=piman@ for //content/common, since only rm'ing unused files. Review-Url: https://codereview.chromium.org/2758163004 Cr-Commit-Position: refs/heads/master@{#458171} Committed: https://chromium.googlesource.com/chromium/src/+/c8328175c9546a643030ac0eb4ce484268d6c668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -103 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/common/establish_channel_params.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/common/establish_channel_params.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/gpu_host_messages.h View 2 chunks +0 lines, -54 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 17 (10 generated)
sadrul
4 months, 1 week ago (2017-03-20 18:34:00 UTC) #4
Tom Sepez
yay! LGTM
4 months, 1 week ago (2017-03-20 18:56:57 UTC) #5
jbauman
lgtm
4 months, 1 week ago (2017-03-20 18:59:58 UTC) #6
sadrul
+piman@ for owner in content/common (will TBR though, since only rm'ing unused files)
4 months, 1 week ago (2017-03-20 19:22:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2758163004/1
4 months, 1 week ago (2017-03-20 19:24:30 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c8328175c9546a643030ac0eb4ce484268d6c668
4 months, 1 week ago (2017-03-20 20:38:42 UTC) #16
piman
4 months, 1 week ago (2017-03-20 21:20:57 UTC) #17
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973